Skip to content

Retire stale support for interactive grid jobs with VNC access#524

Merged
jonasbardino merged 3 commits intonextfrom
adjust/retire-stale-vnc-access-to-grid-jobs
Apr 24, 2026
Merged

Retire stale support for interactive grid jobs with VNC access#524
jonasbardino merged 3 commits intonextfrom
adjust/retire-stale-vnc-access-to-grid-jobs

Conversation

@jonasbardino
Copy link
Copy Markdown
Contributor

@jonasbardino jonasbardino commented Apr 21, 2026

Retire old unused VNC access to grid jobs by removing the Xgi interfaces and functionality backends themselves plus any references to 'interactive' in mRSL, resconf and MiGserver.conf jobtypes entries.
Eliminates some VNC password issues reported by code scans in addition to pruning old unused code.

The remaining references to 'interactive' in liveio and jobstatus are valid and unrelated AFAICT.

Needs testing on a site with jobs and resources enabled but should at least not interfere with non-grid deployments.

… the

resource running the job.
Also removes the stale vnc password handling being flagged in code scans.
Removes the 'interactive' jobtype in mRSL, resconfs and MiGserver.conf files.

The remaining occurences of 'interactive' in jobstatus.py relate to the display
of various job management links and is unrelated AFAICT.
Similarly the ones in liveio.py only refer to operations that communicate with
running (batch) jobs.
@jonasbardino jonasbardino self-assigned this Apr 21, 2026
@jonasbardino jonasbardino added the refactor Non-functional changes to simplify or clean up label Apr 21, 2026
@jonasbardino jonasbardino added this to the Retire legacy components milestone Apr 21, 2026
@jonasbardino jonasbardino added the WiP Work-in-Progress: any review requests do NOT mean it's ready for merge. label Apr 21, 2026
@jonasbardino jonasbardino requested a review from a team April 21, 2026 11:13
@jonasbardino jonasbardino marked this pull request as ready for review April 21, 2026 11:14
Copy link
Copy Markdown
Contributor

@Martin-Rehr Martin-Rehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbardino
Copy link
Copy Markdown
Contributor Author

Tested with generic docker-migrid deployment and fast-tracking merge after approval (thanks @Martin-Rehr) to address the code scan security warnings.

@jonasbardino jonasbardino merged commit a9f76f3 into next Apr 24, 2026
23 checks passed
@jonasbardino jonasbardino deleted the adjust/retire-stale-vnc-access-to-grid-jobs branch April 24, 2026 06:30
@jonasbardino jonasbardino added follow-up pending Pending tasks to follow-up on after close and removed WiP Work-in-Progress: any review requests do NOT mean it's ready for merge. labels Apr 24, 2026
@jonasbardino
Copy link
Copy Markdown
Contributor Author

Added follow-up tag to cover further testing on classic grid compute site deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

follow-up pending Pending tasks to follow-up on after close refactor Non-functional changes to simplify or clean up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants