Replace markitup-1.1.14 with the somewhat less dated 1.1.15 version#538
Open
jonasbardino wants to merge 3 commits intonextfrom
Open
Replace markitup-1.1.14 with the somewhat less dated 1.1.15 version#538jonasbardino wants to merge 3 commits intonextfrom
jonasbardino wants to merge 3 commits intonextfrom
Conversation
Contributor
Author
|
Verified to work on a test deployment. |
…or a few fixes and to see if it helps address the issues highlighted by automatic code scans. We would probably be better of going with a modern and fully maintained solution like TinyMCE instead, but I don't see we can spare the resources for a switch like that at the moment.
…set from 1.1.15 as we probably want to use codemirror over markitup for HTML edits as well.
…set from 1.1.15 as we probably want to use codemirror over markitup for HTML edits as well.
jonasbardino
force-pushed
the
adjust/minor-markitup-version-upgrade
branch
from
5d3b7e0 to
095c9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace markitup-1.1.14 with the somewhat less dated 1.1.15 version for a few fixes and to see if it helps address the issues highlighted by automatic code scans.
We would probably be better of going with a modern and fully maintained solution like TinyMCE instead, but I don't see we can spare the resources for a switch like that at the moment.