Fix lustre quota '.lustrepid' file location#577
Open
Martin-Rehr wants to merge 4 commits into
Open
Conversation
Contributor
|
Restarted failed Rocky10 CI to confirm it was just an upstream repo mirror issue, as output indicated. |
| # Check if quota_lustre_pid is unused | ||
| # and if not find the next unused lustre project id | ||
|
|
||
| max_lustre_pid = 4294967294 |
Contributor
There was a problem hiding this comment.
Unrelated but for the record the pid abbreviation for 'project id' is slightly confusing. It took me a while to realize it's not about a lustre process id like the usual meaning in relation to pid files.
It would be helpful with a comment clearly stating it or perhaps a rename to proj_id or similar at some point.
Contributor
Author
There was a problem hiding this comment.
You are right, changed to projid in the latest commit, which is the term used in the lustre documentation.
jonasbardino
approved these changes
Jun 17, 2026
jonasbardino
left a comment
jonasbardino
left a comment
Contributor
There was a problem hiding this comment.
Approved: looks fine, and only a couple of minor comments you can take or leave before merging.
…ffical lustre abbreviation. Thanks @jonasbardino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes where the
.lustrepidtracking file is written so it correctly passes through encryption in the case where the storage backend islustre-gocryptfs.Previously
__set_project_idwrote the.lustrepidmarker file directly intoquota_datapath, which in thelustre-gocryptfsscenario is the encoded path on the Lustre mount. As a result the file bypassed gocryptfs encryption and madegocryptfscomplain aboutcould not decrypt entry ".lustrepid"(#578).