Implement handling of invalid request markers in create_user as well#607
Open
jonasbardino wants to merge 1 commit into
Open
Implement handling of invalid request markers in create_user as well#607jonasbardino wants to merge 1 commit into
invalid request markers in create_user as well#607jonasbardino wants to merge 1 commit into
Conversation
…ell. That is, make sure that the field does not end up in user DB and that requests detected as invalid during signup/renew are also rejected if handled manually by site admins like they are by the janitor. Add a couple of unit tests to verify `invalid` is honoured for new accounts and for account renewals, while also assuring that valid requests still work and don't result in an (empty list) `invalid` field in the user DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement handling of
invalidrequest markers increate_useras well. That is, make sure that the field does not end up in user DB and that requests detected as invalid during signup/renew are also rejected if handled manually by site admins like they are by the janitor.Add a couple of unit tests to verify
invalidis honored for new accounts and for account renewals, while also assuring that valid requests still work and don't result in an (empty list)invalidfield in the user DB.