Implement main_id conflict checks in create_user#608
Open
jonasbardino wants to merge 1 commit into
Open
Conversation
…sting openid `alias` one. Makes sure that user creation with changed ID fields but same `main_id` is logged and refused with a similar conflict message. That is, basically the first iteration of the solution outlined in #604. Adjusts the unit tests to make sure they cover both the openid `alias` and `main_id` cases and extend to verify that the logs in fact contains the expected warnings to rule out false positives for other exceptions. Added a few more log warnings for similar situations we only had interactive output for. Integrates the typo fixes from #605 to reduce merge conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
main_idconflict checks increate_userto match the existing openidaliasone. Makes sure that user creation with changed ID fields but samemain_idis logged and refused with a similar conflict message. That is, basically the first iteration of the solution outlined in #604. Adjusts the unit tests to make sure they cover both the openidaliasandmain_idcases and extend to verify that the logs in fact contains the expected warnings to rule out false positives for other exceptions. Added a few more log warnings for similar situations we only had interactive output for.Integrates the typo fixes from #605 to reduce merge conflicts.