This repository was archived by the owner on Jun 23, 2022. It is now read-only.
Updated Forecast Adapter using SOLID principles.#335
Open
Sugooi wants to merge 3 commits intoudacity:sunshine_masterfrom
Open
Updated Forecast Adapter using SOLID principles.#335Sugooi wants to merge 3 commits intoudacity:sunshine_masterfrom
Sugooi wants to merge 3 commits intoudacity:sunshine_masterfrom
Conversation
Removed the switches as it was violating the open-close principle.
Updated ForecastAdapter using SOLID principles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using switch code was violating the open-closed principle.