fix(navbar): unify login/register navbar into shared PublicNavBar component - #15
Merged
udaycodespace merged 2 commits intoJul 18, 2026
Merged
Conversation
Contributor
Author
|
@udaycodespace could you add the ECSoC26 label to this PR so Sentinel picks it up? Thanks! |
udaycodespace
self-requested a review
July 18, 2026 13:29
Owner
LGTM. Thanks for the clean refactor and for resolving the reported navbar issue.
|
Contributor
Author
Gotcha , Thank you for info , will look into it in future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Login and Register pages each hardcoded their own copy of the navbar using
premium-nav-links/premium-btnclasses, which are not defined anywhere inApp.css. This caused the nav links ("Home", "Login", "Register") to render
with no spacing at all, running together edge-to-edge (e.g. "HomeLoginRegister")
on both desktop and mobile, with no hamburger menu on small screens.
This PR removes the duplicated, unstyled navbar markup from both pages and
replaces it with a new shared
PublicNavBarcomponent, styled using the site'sexisting
.landing-nav/.nav-text-linkclasses (the same ones already usedcorrectly on the Home page). This keeps the visual design consistent across
Home, Login, and Register, and restores proper mobile behavior via react-bootstrap's
Navbar.Toggle/Navbar.Collapse(hamburger menu).Closes #14
Type of Change
Checklist
Screenshots / Screen Recordings
Before: Login/Register navbar links rendered edge-to-edge with no spacing.

After: Navbar links properly spaced, consistent with Home page styling,

includes working hamburger menu on mobile.