Skip to content

fix(navbar): unify login/register navbar into shared PublicNavBar component - #15

Merged
udaycodespace merged 2 commits into
udaycodespace:mainfrom
Hunter69240:fix/login-register-navbar
Jul 18, 2026
Merged

fix(navbar): unify login/register navbar into shared PublicNavBar component#15
udaycodespace merged 2 commits into
udaycodespace:mainfrom
Hunter69240:fix/login-register-navbar

Conversation

@Hunter69240

Copy link
Copy Markdown
Contributor

Description

The Login and Register pages each hardcoded their own copy of the navbar using
premium-nav-links / premium-btn classes, which are not defined anywhere in
App.css. This caused the nav links ("Home", "Login", "Register") to render
with no spacing at all, running together edge-to-edge (e.g. "HomeLoginRegister")
on both desktop and mobile, with no hamburger menu on small screens.

This PR removes the duplicated, unstyled navbar markup from both pages and
replaces it with a new shared PublicNavBar component, styled using the site's
existing .landing-nav / .nav-text-link classes (the same ones already used
correctly on the Home page). This keeps the visual design consistent across
Home, Login, and Register, and restores proper mobile behavior via react-bootstrap's
Navbar.Toggle/Navbar.Collapse (hamburger menu).

Closes #14

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or console errors.
  • I have tested my changes locally and verified they work as expected.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots / Screen Recordings

Before: Login/Register navbar links rendered edge-to-edge with no spacing.
image

After: Navbar links properly spaced, consistent with Home page styling,
includes working hamburger menu on mobile.
image

@Hunter69240

Copy link
Copy Markdown
Contributor Author

@udaycodespace could you add the ECSoC26 label to this PR so Sentinel picks it up? Thanks!

@udaycodespace udaycodespace added ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points in review PR is up and waiting on maintainer review ECSoC26 Required label for a PR to be eligible for Sentinel scoring and removed frontend labels Jul 18, 2026
@udaycodespace
udaycodespace self-requested a review July 18, 2026 13:29
@udaycodespace udaycodespace added good first issue Beginner-friendly, low context needed to start and removed in review PR is up and waiting on maintainer review labels Jul 18, 2026
@udaycodespace

Copy link
Copy Markdown
Owner

@udaycodespace could you add the ECSoC26 label to this PR so Sentinel picks it up? Thanks!

LGTM. Thanks for the clean refactor and for resolving the reported navbar issue.

  1. One minor suggestion for future improvements would be to use React Router navigation (as={NavLink} / to) for Navbar.Brand instead of href to avoid a full page reload.
  2. This isn't blocking, so approving.

@udaycodespace
udaycodespace merged commit 426f297 into udaycodespace:main Jul 18, 2026
3 checks passed
@ecsoc-sentinel ecsoc-sentinel Bot added ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points and removed ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points labels Jul 18, 2026
@Hunter69240

Copy link
Copy Markdown
Contributor Author

@udaycodespace could you add the ECSoC26 label to this PR so Sentinel picks it up? Thanks!

LGTM. Thanks for the clean refactor and for resolving the reported navbar issue.

  1. One minor suggestion for future improvements would be to use React Router navigation (as={NavLink} / to) for Navbar.Brand instead of href to avoid a full page reload.
  2. This isn't blocking, so approving.

Gotcha , Thank you for info , will look into it in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points ECSoC26 Required label for a PR to be eligible for Sentinel scoring good first issue Beginner-friendly, low context needed to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login/Register navbar renders with no spacing (unstyled duplicated navbar)

2 participants