Skip to content

refactor: extract CSS and JS into modular assets - #34

Merged
udaycodespace merged 1 commit into
udaycodespace:mainfrom
anshika-guleria:chore/refactor-leaderboard-assets
Jul 24, 2026
Merged

refactor: extract CSS and JS into modular assets#34
udaycodespace merged 1 commit into
udaycodespace:mainfrom
anshika-guleria:chore/refactor-leaderboard-assets

Conversation

@anshika-guleria

Copy link
Copy Markdown
Contributor

Related Issue

Closes #32

What I changed

This PR refactors the standalone GitHub Pages leaderboard by separating the HTML, CSS, and JavaScript into dedicated files without changing any functionality or design.

Changes made

  • Moved all inline CSS from index.html to index/css/style.css.
  • Moved all inline JavaScript from index.html to index/js/script.js.
  • Created the index/images/ directory for future leaderboard assets.
  • Updated index.html to load the external stylesheet and JavaScript files.
  • Kept the existing UI, animations, responsiveness, and functionality unchanged.

@udaycodespace

Copy link
Copy Markdown
Owner

Related Issue

Closes #32

What I changed

This PR refactors the standalone GitHub Pages leaderboard by separating the HTML, CSS, and JavaScript into dedicated files without changing any functionality or design.

Changes made

  • Moved all inline CSS from index.html to index/css/style.css.
  • Moved all inline JavaScript from index.html to index/js/script.js.
  • Created the index/images/ directory for future leaderboard assets.
  • Updated index.html to load the external stylesheet and JavaScript files.
  • Kept the existing UI, animations, responsiveness, and functionality unchanged.

LGTM 👍

Could you share a quick screenshot of the final UI before I merge? Just want to verify everything looks the same after the refactor.

@anshika-guleria

Copy link
Copy Markdown
Contributor Author

I am sorry but i will be able to do it by evening will that be alright? @udaycodespace

@udaycodespace

Copy link
Copy Markdown
Owner

I am sorry but i will be able to do it by evening will that be alright? @udaycodespace

That's perfectly fine. Take your time.

Just share the final UI screenshot whenever it's ready. Once I verify everything looks good, I'll proceed with the review and merge.

@anshika-guleria

Copy link
Copy Markdown
Contributor Author
Screenshot (1810) Screenshot (1811) Screenshot (1812) Screenshot (1813) Screenshot (1814)

@udaycodespace udaycodespace added ECSoC26 Required label for a PR to be eligible for Sentinel scoring ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points good-pr PA-awarded bonus for an exceptionally executed PR — +15 XP redo Reviewed — needs changes before it can be merged labels Jul 24, 2026
@udaycodespace

Copy link
Copy Markdown
Owner

@anshika-guleria Thanks for sharing the screenshots.

I meant the standalone leaderboard (index.html), not the app UI.
Could you please share screenshots of the leaderboard page (index.html) after the refactor so I can verify everything remains unchanged?

@anshika-guleria

Copy link
Copy Markdown
Contributor Author
Screenshot (1815) Screenshot (1816) Apologies, I did npm run dev out of habit

@udaycodespace

Copy link
Copy Markdown
Owner

Screenshot (1815) Screenshot (1816) Apologies, I did npm run dev out of habit

Good to go!

@udaycodespace udaycodespace removed the redo Reviewed — needs changes before it can be merged label Jul 24, 2026
@udaycodespace
udaycodespace merged commit c0c734f into udaycodespace:main Jul 24, 2026
2 of 9 checks passed
@ecsoc-sentinel ecsoc-sentinel Bot added ECSoC26-L2 Medium difficulty, auto-assigned by Sentinel — 10 points and removed ECSoC26-L1 Easy difficulty, auto-assigned by Sentinel — 5 points labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26-L2 Medium difficulty, auto-assigned by Sentinel — 10 points ECSoC26 Required label for a PR to be eligible for Sentinel scoring good-pr PA-awarded bonus for an exceptionally executed PR — +15 XP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: Refactor standalone GitHub Pages leaderboard into modular assets

2 participants