Skip to content

Commit 52aa69c

Browse files
committed
docs
1 parent 389c7dd commit 52aa69c

79 files changed

Lines changed: 2941 additions & 4650 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/AGENTS.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,11 @@ Use those skills when relevant:
6262
- `major-task` for heavyweight architecture, framework comparison, migration, benchmark, or proposal work.
6363
- `deslop` for the final bounded cleanup pass once a change already works.
6464
- `tdd`.
65-
- `agent-native-reviewer` when changes touch `.agents/**`, `.claude/**`,
66-
`.codex/**`, skills, hooks, commands, prompts, or user-action tooling.
65+
- For `.agents/**`, `.claude/**`, `.codex/**`, skills, hooks, commands,
66+
prompts, or user-action tooling, use the autogoal agent-native pack and end
67+
with `autoreview`.
6768
- @.agents/rules/changeset.mdc when updating packages.
6869

69-
Convex-specific CE exclusions:
70-
71-
- Do not install or reference these by default in this repo unless the user explicitly asks: `data-integrity-guardian`, `data-migration-expert`, `data-migrations-reviewer`, `schema-drift-detector`, `deployment-verification-agent`, `dhh-rails-reviewer`, `kieran-rails-reviewer`, `kieran-python-reviewer`, `previous-comments-reviewer`, `pr-comment-resolver`, `figma-design-sync`.
72-
- Reason: better-convex is a framework/tooling repo. Data migration, Rails, deployment, PR-thread, and Figma workflow agents are mostly overkill or the wrong shape here.
73-
7470
Goal plans:
7571

7672
- For issue-backed goal work, start the filename with the ticket number.

.agents/rules/agent-browser-issue.mdc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ Body shape:
6060

6161
## After
6262

63-
- if the browser/tool failure exposes a user-action parity gap, load `agent-native-reviewer` and note that gap in the issue
63+
- if the browser/tool failure exposes a user-action parity gap, use the
64+
autogoal agent-native pack and note that gap in the issue
6465
- link the issue in the task caveat or handoff
6566
- keep moving if the product task is still otherwise fixable

.agents/rules/dev-browser.mdc

Lines changed: 0 additions & 129 deletions
This file was deleted.

.agents/rules/major-task.mdc

Lines changed: 30 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Handle $ARGUMENTS. Use this for architectural, comparative, benchmark, migration
1717
- Start from repo constraints, not internet takes.
1818
- Search for existing boundaries, patterns, and prior decisions before inventing new ones.
1919
- Prefer the smallest heavy stack that can answer the decision.
20-
- Usually load 3 to 5 helpers, not every possible helper.
20+
- Usually load 2 to 4 helpers, not every possible helper.
2121
- Separate facts, inference, and recommendation.
2222
- Do not default to review swarms, browser proof, PR work, or compounding.
2323
- Use external docs only when repo evidence and local clones are not enough or the task explicitly depends on third-party behavior.
@@ -138,44 +138,29 @@ Apply this section only when the task source is a tracker item.
138138
the durable working state in one `docs/plans` goal plan. Use
139139
`--template major-task`, then add touched-surface packs for docs, browser,
140140
package/API, or agent-native surfaces.
141-
- `learnings-researcher`
142-
Use early when prior repo decisions, solutions, or repeated failures may matter.
143-
- `repo-research-analyst`
144-
Default repo-grounding helper for major work.
145-
- `architecture-strategist`
146-
Use for public API design, layering, ownership boundaries, abstraction cleanup, and major cross-package refactors.
147-
- `pattern-recognition-specialist`
148-
Use when the question needs repo-wide pattern extraction, repeated smell detection, or design consistency analysis across packages.
149-
- `framework-docs-researcher`
150-
Use only after local clone/source/docs work per AGENTS is not enough, or when competing framework behavior must be grounded in official docs.
151-
- `best-practices-researcher`
152-
Use only when official docs leave gaps or the task genuinely needs broader field patterns beyond official sources.
153-
- `performance-oracle`
154-
Use for benchmark design, scalability analysis, hot-path tradeoffs, or performance validation strategy.
155-
- `spec-flow-analyzer`
156-
Use for RFCs, proposals, acceptance criteria, rollout plans, and completeness pressure-testing.
157-
- `issue-intelligence-analyst` or `git-history-analyzer`
158-
Use only when issue churn, historical regressions, or design history matter to the decision.
159-
- `coherence-reviewer` and `feasibility-reviewer`
160-
Default pair for explicit document review.
161-
- `scope-guardian-reviewer`
162-
Use when scope, abstraction count, or rollout shape may be inflated.
163-
- `product-lens-reviewer`
164-
Use when the document is making product framing, value, or roadmap claims.
165-
- `adversarial-document-reviewer`
166-
Use for larger, riskier, or more assumption-heavy docs where premise stress-testing is worth the cost.
167-
- `correctness-reviewer`, `maintainability-reviewer`, `project-standards-reviewer`, `code-simplicity-reviewer`
168-
Use only when major work actually turns into risky code-changing execution or architecture-sensitive diffs.
169-
- `agent-native-reviewer`
170-
Use only when the change touches `.agents/**`, `.claude/**`, AI/tooling surfaces, commands, or user actions that an agent should also be able to perform.
171-
- `browser-use`
172-
Use only when there is a real browser surface to verify.
141+
- `research-wiki`
142+
Use when prior repo decisions, solutions, research artifacts, or repeated
143+
failures may matter.
144+
- `diagnosing-bugs`
145+
Use when the major task is still a failure-mode investigation rather than a
146+
design decision.
147+
- `deslop`
148+
Use after a working change when the remaining risk is code shape, simplicity,
149+
over-abstraction, or AI-generated sludge.
150+
- `tdd`
151+
Use when package behavior changes and the next step should be a focused
152+
executable contract before implementation.
153+
- `autoreview`
154+
Use for explicit diff review, release-readiness review, or final review of a
155+
risky code-changing slice.
156+
- Agent-native surfaces
157+
Use the autogoal agent-native pack and `autoreview` when the change touches
158+
`.agents/**`, `.claude/**`, AI/tooling surfaces, commands, or user actions
159+
that an agent should also be able to perform.
173160
- `agent-browser-issue`
174161
Use when browser automation is blocked by a likely reusable tool-side issue that deserves a separate GitHub follow-up.
175162
- `changeset`
176163
Use when verified work changes a published package under `packages/` and the repo expects release notes before completion.
177-
- `git-commit-push-pr`
178-
Use when verified code-changing work should ship as a PR.
179164
## Execution Paths
180165

181166
### Architecture Or Public API
@@ -227,7 +212,8 @@ Apply this section only when the task source is a tracker item.
227212

228213
### Spec Or Proposal
229214

230-
1. Use `spec-flow-analyzer` to pressure-test completeness.
215+
1. Pressure-test completeness directly against source, current constraints,
216+
acceptance criteria, rollout, and verification.
231217
2. Define constraints, acceptance criteria, rollout, verification, and open questions before implementation.
232218
3. If the task is still mushy product framing rather than implementation
233219
strategy, stop for focused clarification or switch to collaborative planning.
@@ -236,13 +222,14 @@ Apply this section only when the task source is a tracker item.
236222
### Document Review
237223

238224
1. Use this path only for explicit plan, RFC, proposal, or spec review.
239-
2. Default review pair:
240-
- `coherence-reviewer`
241-
- `feasibility-reviewer`
242-
3. Add `scope-guardian-reviewer` when the document introduces multiple new abstractions, broad rollout shape, or scope that may have drifted past the stated goal.
243-
4. Add `product-lens-reviewer` when the document is making product framing, roadmap, UX-value, or "are we solving the right thing?" claims.
244-
5. Add `adversarial-document-reviewer` when the document has more than 5 requirements or implementation units, makes significant architectural decisions, proposes new abstractions, or feels high-stakes enough that premise stress-testing is worth the cost.
245-
6. Keep this pass selective. Most docs should not load every reviewer.
225+
2. Review with one compact pass:
226+
- coherence: does the proposal contradict itself?
227+
- feasibility: can the repo implement and verify it?
228+
- scope: are abstractions, rollout, and proof proportional?
229+
- product fit: does it solve the right problem for this repo?
230+
- adversarial pass: what would make this plan fail?
231+
3. Use `autoreview` only when there is an actual diff or final review target.
232+
4. Keep this pass selective. Most docs should not need another skill.
246233

247234
### Mixed Major Work
248235

.agents/rules/task.mdc

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ lock.
200200
- `tdd`: bugs and feature work where behavior-level automated coverage is sane.
201201
- `learnings-researcher`: non-trivial repeated domains with documented
202202
solutions.
203-
- `debug`: fuzzy failures after the first repro pass or failing test.
204203
- `video-transcripts`: tracker evidence contains a video or screen recording.
205204
- If requirements remain ambiguous after source and local context, ask the
206205
smallest clarifying question or switch to a planning goal when the user wants
@@ -217,20 +216,18 @@ lock.
217216
- Docs/content work: use `--template docs` when docs dominate; use `--with docs`
218217
when docs are a supporting touched surface. For `www/**`, keep matching
219218
`packages/kitcn/skills/kitcn/**` content in sync.
220-
- `git-commit-push-pr`: verified code should ship as a commit and PR unless
221-
the user explicitly says not to, or the work is analytical, blocked,
222-
inconclusive, or has no local patch. This is a task-skill requirement, so it
223-
satisfies the repo git permission policy. Stage the entire current checkout
219+
- Git/PR shipping: when verified code should ship and repo policy permits it,
220+
use normal `git`/`gh` commands directly. Stage the entire current checkout
224221
per repo policy when creating the PR, create the commit, push, create or
225222
update the PR before tracker comments. The `task` skill owns the PR body:
226-
use `git-commit-push-pr` for git/gh transport, then write the PR description
227-
from the task-style final handoff contract below instead of the generic
228-
adaptive PR summary. Do not skip this merely because the user did not type a
229-
separate "open a PR" sentence.
223+
write the PR description from the task-style final handoff contract below.
224+
Do not skip this merely because the user did not type a separate "open a PR"
225+
sentence.
230226
- Review skills: load only for risky, large, user-facing, or
231227
architecture-sensitive changes.
232-
- `agent-native-reviewer`: changes touch `.agents/**`, `.claude/**`,
233-
AI/tooling surfaces, commands, or user actions an agent should perform.
228+
- Agent-native surface: when changes touch `.agents/**`, `.claude/**`,
229+
AI/tooling surfaces, commands, or user actions an agent should perform, use
230+
the autogoal agent-native pack and end with `autoreview`.
234231

235232
## Review And Risk Gates
236233

@@ -241,9 +238,9 @@ real closeout pressure.
241238
- Autoreview is a hard closeout gate for non-trivial implementation changes.
242239
Load `.agents/skills/autoreview/SKILL.md`, pick the target from the actual
243240
diff state, and keep going until there are no accepted/actionable findings.
244-
- `agent-native-reviewer` is required when the task changes `.agents/**`,
245-
`.claude/**`, `.codex/**`, skills, hooks, commands, prompts, or user-action
246-
tooling.
241+
- The autogoal agent-native pack plus `autoreview` are required when the task
242+
changes `.agents/**`, `.claude/**`, `.codex/**`, skills, hooks, commands,
243+
prompts, or user-action tooling.
247244
- Source authority is workspace-local. A check run in the planning repo cannot
248245
prove behavior owned by a sibling repo, package, app, browser route, or
249246
tracker system. Record the cwd/tool that owns each proof.
@@ -359,9 +356,9 @@ Keep verification mandatory and proportional.
359356
## Task-Style PR Body
360357

361358
When a `task` run creates or updates a PR, the PR description must mirror the
362-
task final handoff. Do not use a generic `Summary` / `Verification` PR body, an
363-
adaptive prose body from `git-commit-push-pr`, or a generated badge footer
364-
unless the caller or repo template explicitly asks for it.
359+
task final handoff. Do not use a generic `Summary` / `Verification` PR body,
360+
generic git-helper prose, or a generated badge footer unless the caller or repo
361+
template explicitly asks for it.
365362

366363
Use the accepted task PR format from PR #270. The shape is not optional:
367364

0 commit comments

Comments
 (0)