Merge pull request #4931 from udecode/codex/table-shift-arrow-eager-selection-2

Author: zbeyens

.changeset/funny-years-arrive.md

@@ -0,0 +1,5 @@
+---
+"@platejs/table": patch
+---
+
+Fix `Shift+Arrow` table selection to switch cells without showing a transient native range

.claude/docs/plans/2026-03-31-table-shift-arrow-eager-selection.md

@@ -0,0 +1,42 @@
+# Table Shift Arrow Eager Selection
+
+## Goal
+
+Remove the transient native text-range flash when `Shift+Arrow` expands from one table cell into another.
+
+## Plan
+
+- [completed] Add keydown-level regression coverage for eager single-cell `Shift+Arrow`.
+- [completed] Route single-cell `Shift+Arrow` through table-owned selection movement before native selection applies.
+- [completed] Remove `withApplyTable` repair behavior and delete `overrideSelectionFromCell`.
+- [completed] Update coverage and docs to reflect keydown-only ownership.
+- [completed] Run focused tests, package build, typecheck, lint.
+
+## Findings
+
+- Multi-cell `Shift+Arrow` already goes through `onKeyDownTable`.
+- Single-cell cross-cell expansion still waits for `set_selection` and `setTimeout`, which causes visible flash.
+- The quick fix is to take ownership in `onKeyDownTable` for the one-cell boundary-crossing case too.
+- `overrideSelectionFromCell` is now a redundant apply-time fallback unless a real non-keydown caller still depends on it.
+
+## Progress
+
+- Created plan for eager single-cell `Shift+Arrow` interception.
+- Added `onKeyDownTable` coverage for eager single-cell `Shift+Down` and `Shift+Right`.
+- Extracted the visual-line boundary check into a shared helper so plain arrows and shifted arrows use the same vertical edge rule.
+- Routed one-cell cross-cell `Shift+Arrow` through `onKeyDownTable` before native selection applies.
+- Removed the apply-time fallback and deleted `overrideSelectionFromCell` plus its dedicated tests.
+- Added a package changeset and a solution doc for the timing seam.
+- Follow-up refactor: extracted shared single-cell table movement context and adjacent-block checks used by both `moveLine` and `onKeyDownTable`.
+- Follow-up tests: added `Shift+Up`, `Shift+Left`, and multi-cell `Shift+Right` keydown coverage.
+
+## Verification
+
+- `bun test packages/table/src/react/onKeyDownTable.spec.tsx`
+- `bun test packages/table/src/react/onKeyDownTable.spec.tsx packages/table/src/lib/withApplyTable.spec.ts packages/table/src/lib/withTable.spec.tsx packages/table/src/lib/transforms/moveSelectionFromCell.spec.tsx`
+- `pnpm install`
+- `pnpm turbo build --filter=./packages/table`
+- `pnpm turbo typecheck --filter=./packages/table`
+- `pnpm lint:fix`
+- `bun test packages/table/src/react/onKeyDownTable.spec.tsx`
+- `bun test packages/table/src/lib/withTable.spec.tsx packages/table/src/lib/transforms/shouldMoveSelectionFromCell.spec.ts packages/table/src/lib/transforms/moveSelectionFromCell.spec.tsx packages/table/src/lib/withApplyTable.spec.ts`

.claude/docs/solutions/logic-errors/2026-03-31-table-shift-arrow-selection-must-own-keydown-before-native-selection.md

@@ -0,0 +1,76 @@
+---
+module: Table
+date: 2026-03-31
+problem_type: logic_error
+component: editor_transforms
+symptoms:
+  - "Shift+Arrow from one table cell into another briefly showed a native text range before cell selection took over"
+  - "Cross-cell Shift+Down and Shift+Right felt delayed even though the final cell selection was correct"
+root_cause: async_timing
+resolution_type: code_fix
+severity: medium
+tags:
+  - table
+  - selection
+  - keyboard
+  - shift-arrow
+  - timing
+  - keydown
+  - slate
+---
+
+# Table Shift+Arrow selection must own keydown before native selection
+
+## Problem
+
+Single-cell `Shift+Arrow` expansion across table cell boundaries produced the correct final cell selection, but only after a visible intermediate native range.
+
+The flash was most obvious on `Shift+Down` and `Shift+Right`, where the browser first painted a normal text selection and table code repaired it one tick later.
+
+## Root cause
+
+Table selection only owned multi-cell `Shift+Arrow` at keydown time.
+
+The one-cell case relied on apply-time repair after native selection had already moved once, which produced a visible intermediate text range.
+
+## Fix
+
+Take ownership of the one-cell boundary-crossing case in `onKeyDownTable` before native selection applies, and remove the apply-time repair path.
+
+- Keep the existing eager multi-cell `Shift+Arrow` path.
+- Add a one-cell path that checks whether the moving focus edge is about to leave the current cell.
+- For `Shift+Up` and `Shift+Down`, reuse the same visual-line boundary logic as plain `moveLine`.
+- For `Shift+Left` and `Shift+Right`, only intercept when the focus is already at the cell start or end.
+- When the boundary test passes, call `moveSelectionFromCell(..., { fromOneCell: true })` immediately and prevent the native event.
+- Delete `overrideSelectionFromCell` and stop calling it from `withApplyTable`.
+
+That moves the ownership seam fully to keydown-time interception.
+
+## Verification
+
+These checks passed:
+
+```bash
+bun test packages/table/src/react/onKeyDownTable.spec.tsx packages/table/src/lib/withApplyTable.spec.ts packages/table/src/lib/withTable.spec.tsx packages/table/src/lib/transforms/moveSelectionFromCell.spec.tsx
+pnpm install
+pnpm turbo build --filter=./packages/table
+pnpm turbo typecheck --filter=./packages/table
+pnpm lint:fix
+```
+
+The new coverage proves:
+
+- `onKeyDownTable.spec.tsx` eagerly expands `Shift+Down` and `Shift+Right` from one cell into the adjacent cell
+- `onKeyDownTable.spec.tsx` keeps `Shift+Down` native while the focus can still move within the current multi-block cell
+
+## Prevention
+
+If a keyboard interaction should never show an intermediate native selection state, do not repair it later in `apply`.
+
+Own it at the keydown seam instead of carrying a second repair path that can drift from the real behavior.
+
+When plain-arrow and shifted-arrow movement share the same visual boundary rule, put that boundary check in one helper so the two seams cannot drift.
+
+## Related Issues
+
+- Related learning: [2026-03-29-table-arrow-navigation-must-own-moveline-and-visual-line-boundaries.md](/Users/hyeongjin/Workspace/plate/.claude/docs/solutions/logic-errors/2026-03-29-table-arrow-navigation-must-own-moveline-and-visual-line-boundaries.md)

packages/table/src/lib/transforms/index.ts

@@ -9,9 +9,9 @@ export * from './insertTable';
 export * from './insertTableColumn';
 export * from './insertTableRow';
 export * from './moveSelectionFromCell';
-export * from './overrideSelectionFromCell';
 export * from './setBorderSize';
 export * from './setCellBackground';
 export * from './setTableColSize';
 export * from './setTableMarginLeft';
 export * from './setTableRowSize';
+export * from './shouldMoveSelectionFromCell';