Fix lints

Author: udoprog

.github/workflows/release.yml

@@ -53,11 +53,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - uses: actions/download-artifact@v4
+    - uses: actions/download-artifact@v7
       with: {name: dist-macos-latest, path: dist}
-    - uses: actions/download-artifact@v4
+    - uses: actions/download-artifact@v7
       with: {name: dist-windows-latest, path: dist}
-    - uses: actions/download-artifact@v4
+    - uses: actions/download-artifact@v7
       with: {name: dist-ubuntu-latest, path: dist}
     - uses: udoprog/kick@nightly
     - run: kick github-release --upload "dist/*" --github-action

bot/src/module/gtav.rs

@@ -663,7 +663,7 @@ impl Handler {
             }
         }
 
-        remaining.sort_by(|a, b| b.1.cmp(&a.1));
+        remaining.sort_by_key(|v| v.1);
 
         match remaining.into_iter().next() {
             Some((name, remaining)) => Some((name, remaining)),

bot/src/module/poll.rs

@@ -132,7 +132,7 @@ impl ActivePoll {
             ));
         }
 
-        results.sort_by(|a, b| b.1.cmp(&a.1));
+        results.sort_by_key(|v| v.1);
         results
     }
 }

bot/src/module/promotions.rs

@@ -153,7 +153,7 @@ struct PromoData<'a> {
 
 /// Pick the best promo.
 fn pick(mut promotions: Vec<Arc<db::Promotion>>) -> Option<Arc<db::Promotion>> {
-    promotions.sort_by(|a, b| a.promoted_at.cmp(&b.promoted_at));
+    promotions.sort_by_key(|v| v.promoted_at);
 
     let now = Utc::now();
 

bot/src/updater.rs

@@ -42,7 +42,7 @@ pub(crate) fn updater(
                         Some(cache) => cache.wrap(String::from("updater/version"), chrono::Duration::hours(1), future).await?,
                     };
 
-                    releases.sort_by(|a, b| b.published_at.cmp(&a.published_at));
+                    releases.sort_by_key(|v| v.published_at);
 
                     let release = match releases.into_iter().find(|r| !r.prerelease) {
                         Some(release) => release,

crates/oxidize-settings/src/lib.rs

@@ -46,7 +46,7 @@ pub enum Error {
     MigrationIncompatible {
         from: String,
         to: String,
-        ty: Type,
+        ty: Box<Type>,
         json: String,
     },
     #[error("{0}")]
@@ -484,7 +484,7 @@ where
                 return Err(Error::MigrationIncompatible {
                     from: from_key.to_string(),
                     to: to_key.to_string(),
-                    ty: to.schema.ty.clone(),
+                    ty: Box::new(to.schema.ty.clone()),
                     json: serde_json::to_string(&from)?,
                 });
             }