Skip to content

fix: Link target attribute parsing to match serialization #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkesberg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Link target attribute parsing to match serialization #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e79c6
test: add target null checks
dkesberg Mar 25, 2026
0544a39
fix: initialize target as null when missing from the HTML
dkesberg Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Marks/Link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ public function parseHTML()
return false;
}

return null;
return [
'target' => $DOMNode->getAttribute('target') ?: null,
];
},
],
];
Expand Down
11 changes: 7 additions & 4 deletions tests/DOMParser/Marks/LinkTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
'type' => 'link',
'attrs' => [
'href' => 'https://tiptap.dev',
'target' => null,
],
],
],
Expand Down Expand Up @@ -56,6 +57,7 @@
'attrs' => [
'href' => 'https://tiptap.dev',
'rel' => 'noopener',
'target' => null,
],
],
],
Expand Down Expand Up @@ -86,6 +88,7 @@
'attrs' => [
'href' => 'https://tiptap.dev',
'class' => 'tiptap',
'target' => null,
],
],
],
Expand Down Expand Up @@ -143,10 +146,10 @@ function getInvalidUrls()
return [
// A standard JavaScript protocol
"javascript:alert(window.origin)",

// The protocol is not case sensitive
"jAvAsCrIpT:alert(window.origin)",

// Characters \x01-\x20 are allowed before the protocol
"\x00javascript:alert(window.origin)",
"\x01javascript:alert(window.origin)",
Expand Down Expand Up @@ -180,12 +183,12 @@ function getInvalidUrls()
"\x1djavascript:alert(window.origin)",
"\x1ejavascript:alert(window.origin)",
"\x1fjavascript:alert(window.origin)",

// Characters \x09,\x0a,\x0d are allowed inside the protocol
"java\x09script:alert(window.origin)",
"java\x0ascript:alert(window.origin)",
"java\x0dscript:alert(window.origin)",

// Characters \x09,\x0a,\x0d are allowed after protocol name before the colon
"javascript\x09:alert(window.origin)",
"javascript\x0a:alert(window.origin)",
Expand Down