Skip to content

Commit 92627a7

Browse files
authored
fix: add missing onChange dependency to handleChangeCallback (#199)
1 parent 09ed844 commit 92627a7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/color-compact/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ const Compact = React.forwardRef<HTMLDivElement, CompactProps<React.MouseEvent<H
9393
} = props;
9494
const hsva = (typeof color === 'string' && validHex(color) ? hexToHsva(color) : color) as HsvaColor;
9595
const hex = color ? hsvaToHex(hsva).replace(/^#/, '') : '';
96-
const handleChangeCallback = useCallback((hsv: HsvaColor) => onChange && onChange(handleColor(hsv)), []);
96+
const handleChangeCallback = useCallback((hsv: HsvaColor) => onChange && onChange(handleColor(hsv)), [onChange]);
9797
const handleHex = (value: string | number, evn: React.ChangeEvent<HTMLInputElement>) => {
9898
if (typeof value === 'string' && validHex(value) && /(3|6)/.test(String(value.length))) {
9999
handleChangeCallback(hexToHsva(value));

0 commit comments

Comments
 (0)