#1458 - fix hostname is not updated

Author: ukanth

app/src/main/java/dev/ukanth/ufirewall/activity/LogDetailActivity.java

@@ -174,8 +174,13 @@ private void initializeRecyclerView(final Context ctx) {
             menu.add(0, v.getId(), 4, R.string.ping_source);
             menu.add(0, v.getId(), 5, R.string.resolve_destination);
             menu.add(0, v.getId(), 6, R.string.resolve_source);
-            menu.add(0, v.getId(), 9, "Block this destination permanently");
-            menu.add(0, v.getId(), 10, "Whitelist this destination");
+            // Only show Copy Domain if a hostname was resolved
+            String hostname = current_selected_logData.getHostname();
+            if (hostname != null && !hostname.trim().isEmpty() && !hostname.equals(current_selected_logData.getDst())) {
+                menu.add(0, v.getId(), 9, R.string.copy_domain);
+            }
+            menu.add(0, v.getId(), 10, "Block this destination permanently");
+            menu.add(0, v.getId(), 11, "Whitelist this destination");
             LogPreference logPreference = SQLite.select()
                     .from(LogPreference.class)
                     .where(LogPreference_Table.uid.eq(uid)).querySingle();
@@ -266,10 +271,19 @@ public boolean onContextItemSelected(MenuItem item) {
             case 8:
                 G.updateLogNotification(uid, true);
                 break;
-            case 9: // Block destination permanently
+            case 9: // Copy Domain
+                String domain = current_selected_logData.getHostname();
+                if (domain != null && !domain.trim().isEmpty() && !domain.equals(current_selected_logData.getDst())) {
+                    Api.copyToClipboard(LogDetailActivity.this, domain);
+                    Api.toast(LogDetailActivity.this, getString(R.string.domain_copied));
+                } else {
+                    Api.toast(LogDetailActivity.this, getString(R.string.no_domain_resolved));
+                }
+                break;
+            case 10: // Block destination permanently
                 showBlockDestinationDialog();
                 break;
-            case 10: // Whitelist destination
+            case 11: // Whitelist destination
                 showWhitelistDestinationDialog();
                 break;
 

app/src/main/java/dev/ukanth/ufirewall/log/LogInfo.java

@@ -322,16 +322,8 @@ public static LogInfo parseLogs(String result, final Context ctx, String pattern
                 address.append(":");
                 address.append(logInfo.dpt);
                 logInfo.type = type;
-                if (G.showHost() && (G.isDoKey(ctx) || G.isDonate())) {
-                    try {
-                        String add  = InetAddress.getByName(logInfo.dst).getHostName();
-                        if (add != null) {
-                            logInfo.host = add;
-                            address.append("(").append(add).append(") ");
-                        }
-                    } catch (Exception e) {
-                    }
-                }
+                // Hostname resolution is handled asynchronously in LogService.store()
+                // to avoid blocking the log parsing callback thread
                 address.append("\n");
                 logInfo.timestamp = System.currentTimeMillis();
                 logInfo.uidString = address.toString();

app/src/main/java/dev/ukanth/ufirewall/service/LogService.java

@@ -801,13 +801,26 @@ private static void store(final LogInfo logInfo, Context context) {
                 data.setUid(logInfo.uid);
                 data.setAppName(logInfo.appName);
                 data.setType(logInfo.type);
-                if (G.isDoKey(context) || G.isDonate()) {
-                    try {
-                        data.setHostname(logInfo.host != null ? logInfo.host : "");
-                    } catch (Exception e) {
-                    }
-                }
                 data.setType(0);
+                
+                // Resolve hostname asynchronously if enabled
+                if (G.showHost() && logInfo.dst != null && !logInfo.dst.isEmpty()) {
+                    final String dstIp = logInfo.dst;
+                    final LogData dataRef = data;
+                    new Thread(() -> {
+                        try {
+                            String hostname = java.net.InetAddress.getByName(dstIp).getHostName();
+                            if (hostname != null && !hostname.equals(dstIp)) {
+                                dataRef.setHostname(hostname);
+                                FlowManager.getDatabase(LogDatabase.class)
+                                    .beginTransactionAsync(dw -> dataRef.save(dw))
+                                    .build().execute();
+                            }
+                        } catch (Exception e) {
+                            // DNS resolution failed, hostname will remain empty
+                        }
+                    }, "LogService-DNS-" + dstIp.hashCode()).start();
+                }
                 FlowManager.getDatabase(LogDatabase.class).beginTransactionAsync(databaseWrapper ->
                         data.save(databaseWrapper)).build().execute();
             }

app/src/main/res/values/strings.xml

@@ -520,6 +520,9 @@
     <string name="copy_text">Copy text</string>
     <string name="destination_copied">Destination copied</string>
     <string name="source_copied">Source copied</string>
+    <string name="copy_domain">Copy Domain</string>
+    <string name="domain_copied">Domain copied</string>
+    <string name="no_domain_resolved">No domain resolved for this entry</string>
     <string name="select_the_action">Select The Action</string>
     <string name="result_copied_to_clipboard">Result copied to clipboard</string>
     <string name="result">Result</string>