Support disabling the reset of the logging system#430
Open
jpmsilva wants to merge 1 commit into
Open
Conversation
Author
|
Also, for the time being, we will stay on 3.0.5, as the logging system reset in the 4.x line is a breaking change for our use cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows disabling the logging system reset introduced with com.ulisesbocchio.jasyptspringboot.configuration.EnableEncryptablePropertiesBeanFactoryPostProcessor#reinitializeLoggingSystem
The default behavior is to still reset the logging system unless otherwise specified.
A new Spring Boot property is introduced, called
jasypt.encryptor.reset-logging-system, which, when set to false, disables the reset behavior.We support early logging customization with an ApplicationContextInitializer. Our customizations dynamically introduce appenders and logging filters, depending on environmental conditions. We do this very early to capture as much of the log of the startup sequence as possible.
Resetting the logging system after the fact introduced all sort of issues. Any customizations are lost, and we lose things like the SLF4JBridgeHandler (see #428), as well as things like stdout/stderr capturing (see uk.org.lidalia:sysout-over-slf4j).
This PR aims to allow an easy configuration to disable that behavior, if one does not rely on encrypted properties in the logging system. It also creates a workaround for #428.