Skip to content

Experiment v1/chat#74

Open
glenn-jocher wants to merge 23 commits into
mainfrom
v1-chat-backend
Open

Experiment v1/chat#74
glenn-jocher wants to merge 23 commits into
mainfrom
v1-chat-backend

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Dec 21, 2025

Copy link
Copy Markdown
Member

Summary

Keeps the v1 chat backend experiment open for side-by-side performance profiling without merging it into main.

  • Changes the widget default from the legacy Cloud Run endpoint to https://ul.run/chat/v1/chat on this branch.
  • Adds a 30-question browser benchmark comparing the legacy and v1 endpoints.
  • Measures time to first SSE event (TTFE), with mean, standard deviation, min/max, sample count, and errors.
  • Interleaves the endpoints and alternates which runs first to reduce load and time-order bias.

The benchmark must run from an origin allowed by both backends (such as the deployed llm demo).

@vercel

vercel Bot commented Dec 21, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
llm Ready Ready Preview, Comment Jul 10, 2026 9:42pm

Request Review

@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/llm 🚀 PR! This is an automated message to help with review—an Ultralytics engineer will assist shortly. 🛠️

-✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
-✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/llm main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
-✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
-✅ Update Documentation: Update the relevant documentation for any new or modified features.
-✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
-✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
-✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Clean PR. The default apiUrl update in js/chat.js and corresponding js/chat.min.js change are consistent and should not affect existing integrations that override apiUrl. No issues found in the changed lines.

📋 Skipped 1 file (lock files, minified, images, etc.)
  • js/chat.min.js

@codecov

codecov Bot commented Dec 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants