Experiment v1/chat#74
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Hello @glenn-jocher, thank you for submitting a -✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions. For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Clean PR. The default apiUrl update in js/chat.js and corresponding js/chat.min.js change are consistent and should not affect existing integrations that override apiUrl. No issues found in the changed lines.
📋 Skipped 1 file (lock files, minified, images, etc.)
js/chat.min.js
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
This reverts commit c317ad7.
Summary
Keeps the v1 chat backend experiment open for side-by-side performance profiling without merging it into
main.https://ul.run/chat/v1/chaton this branch.The benchmark must run from an origin allowed by both backends (such as the deployed llm demo).