Close button#85
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Good UX addition overall, but there are a few functional issues to address before merging: the new close button is nested inside a button, storage access is unguarded, the dismiss action is not reachable on touch devices, and the dismissed pill remains keyboard-focusable while invisible.
💬 Posted 4 inline comments
📋 Skipped 1 file (lock files, generated, images, etc.)
js/chat.min.js
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 2
Made with ❤️ by Ultralytics Actions
Nice, focused UI change overall, but there are a few functional issues to address before merging: the new close control is nested inside a button, the dismiss action is hover-only so it is not reliably usable on touch devices, and the hidden state is not actually persisted across reloads.
💬 Posted 3 inline comments
📋 Skipped 1 file (lock files, generated, images, etc.)
js/chat.min.js
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Adds a dismissible close button to the chat launcher pill, letting users hide it temporarily while preserving a quick keyboard path to restore and reopen chat. 🚀
📊 Key Changes
ult-pill-closebutton to the chat pill UI with hover-reveal styling and responsive sizing. ❌circleXicon for the close control injs/chat.js.localStorageusingult-pill-hiddenso the hidden state survives reloads. 💾pill-dismissedclass to animate and disable the pill after dismissal.stopPropagation()to avoid opening chat when dismissing the pill.js/chat.min.js.🎯 Purpose & Impact
📋 Skipped 1 file (lock files, generated, images, etc.)
js/chat.min.js