Skip to content

Upgrade GitHub Actions (CI) and Node.js versions #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adevade wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −7
Open

Upgrade GitHub Actions (CI) and Node.js versions #4016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: pnpm/action-setup@v4
with:
version: 10
run_install: false
- name: Use Node.js 18.18
uses: actions/setup-node@v4
version: latest
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm/action-setup is configured with version: latest, which makes CI non-reproducible and can cause unexpected breakages when pnpm releases new majors. Pin pnpm to a specific major/minor (ideally matching the lockfile/tooling expectations) instead of tracking latest.

Suggested change
version: latest
version: 9

Copilot uses AI. Check for mistakes.
- name: Use Node.js 24
uses: actions/setup-node@v6
with:
Comment on lines +15 to 21
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow bumps actions/checkout and actions/setup-node to @v6, but other workflows in this repo still use older majors (e.g. checkout@v5 in cd.yml, checkout@v3 in cd-cloud.yml). If the intent is a repo-wide Actions upgrade, consider aligning these versions across workflows to reduce maintenance overhead and avoid different behavior between pipelines.

Copilot uses AI. Check for mistakes.
node-version: 18.18
cache: "pnpm"
node-version: 24
Comment on lines +19 to +22
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js 24 is significantly newer than documented requirement (18.18+). Consider:

  • Updating README.md to reflect minimum supported version
  • Verifying production Dockerfile (currently uses Node 22) aligns with CI testing
  • Ensuring all dependencies support Node 24

The jump from 18.18 → 24 may expose issues in user environments still on older versions.

cache: pnpm
- run: npm install --global pnpm
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI currently sets up pnpm via pnpm/action-setup, but then also runs npm install --global pnpm. This is redundant and can override the pnpm version you intended to use (especially when combined with version: latest). Prefer a single installation mechanism (either rely on pnpm/action-setup or install via npm/corepack) to keep the toolchain deterministic.

Suggested change
- run: npm install --global pnpm

Copilot uses AI. Check for mistakes.
- run: pnpm install
- run: pnpm test
Expand Down
Loading