fix: guard against empty BaseUrl to prevent file:// scheme error (#10)#127
Open
Amalie-Wowern wants to merge 3 commits into
Open
fix: guard against empty BaseUrl to prevent file:// scheme error (#10)#127Amalie-Wowern wants to merge 3 commits into
Amalie-Wowern wants to merge 3 commits into
Conversation
When BaseUrl is not configured in appsettings, the URI resolves to file:// which throws NotSupportedException in LoggingHttpMessageHandler. Guard with IsNullOrWhiteSpace check before setting BaseAddress.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes umbraco/Umbraco.Integrations.Issues#10
Root cause: When
BaseUrlis not configured in appsettings,$"{baseUrl}/api/3/"evaluates to"/api/3/".new Uri("/api/3/")resolves against the process working directory, producing afile://scheme URL.LoggingHttpMessageHandlerthen throwsNotSupportedException: The 'file' scheme is not supported.Fix: Read
BaseUrlinto a local variable and wrap theBaseAddress+Api-Tokensetup in a!string.IsNullOrWhiteSpace(baseUrl)guard. The HTTP client is still registered when unconfigured — calls will fail at request time with a clearer relative-URI error rather than crashing during DI initialization.Files changed:
src/Umbraco.Forms.Integrations.Crm.ActiveCampaign/ActiveCampaignComposer.cs