Skip to content

Commit b514b7b

Browse files
authored
Merge pull request #97 from umd-lib/feature/LIBDRUM-1007
LIBDRUM-1007. Remove Wufoo Feedback customization
2 parents bdf5bfb + 3cdb141 commit b514b7b

13 files changed

Lines changed: 8 additions & 140 deletions

src/app/info/info-routes.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
// UMD Customization
2-
/* eslint-disable import-newlines/enforce */
3-
/* eslint-disable simple-import-sort/imports */
4-
// End Customization
51
import {
62
Route,
73
Routes,
@@ -24,17 +20,13 @@ import {
2420
} from './info-routing-paths';
2521
import { NotifyInfoComponent } from './notify-info/notify-info.component';
2622
import { ThemedPrivacyComponent } from './privacy/themed-privacy.component';
27-
// UMD Customization
28-
import { WufooFeedbackResolver } from '../wufoo/wufoo-feedback-resolver';
29-
// End UMD Customization
23+
3024

3125
export const ROUTES: Routes = [
3226
{
3327
path: FEEDBACK_PATH,
3428
component: ThemedFeedbackComponent,
35-
// UMD Customization
36-
resolve: { breadcrumb: i18nBreadcrumbResolver, wufoo: WufooFeedbackResolver },
37-
// End UMD Customization
29+
resolve: { breadcrumb: i18nBreadcrumbResolver },
3830
data: { title: 'info.feedback.title', breadcrumbKey: 'info.feedback' },
3931
canActivate: [feedbackGuard],
4032
},

src/app/wufoo/wufoo-feedback-resolver.ts

Lines changed: 0 additions & 71 deletions
This file was deleted.

src/app/wufoo/wufoo-feedback-response.model.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/assets/i18n/en.json5

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7192,8 +7192,6 @@
71927192

71937193
"home.top-level-communities.head": "Communities in DRUM",
71947194

7195-
"info.feedback.info": "Thanks for sharing your feedback about DRUM. Your comments are appreciated!",
7196-
71977195
"item.page.advisor": "Advisor",
71987196

71997197
"item.page.citation.datasetOrSoftware": "Related Publication Citation",

src/themes/drum/app/footer/footer.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<div class="bottom-footer p-1 d-flex justify-content-center align-items-center">
4141
<div class="content-container">
4242
<ul class="footer-info list-unstyled small d-flex justify-content-center mb-0">
43-
<li>
43+
<li *ngIf="showSendFeedback$ | async">
4444
<a skipLocationChange="true" routerLink="info/feedback">{{ 'footer.link.feedback' | translate}}</a>
4545
</li>
4646
<li>

src/themes/drum/app/footer/footer.component.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
import { NgIf } from '@angular/common';
1+
import {
2+
AsyncPipe,
3+
NgIf,
4+
} from '@angular/common';
25
import { Component } from '@angular/core';
36
import { RouterLink } from '@angular/router';
47
import { TranslateModule } from '@ngx-translate/core';
@@ -9,7 +12,7 @@ import { FooterComponent as BaseComponent } from '../../../../app/footer/footer.
912
selector: 'ds-themed-footer',
1013
styleUrls: ['footer.component.scss'],
1114
templateUrl: 'footer.component.html',
12-
imports: [NgIf, RouterLink, TranslateModule],
15+
imports: [NgIf, RouterLink, AsyncPipe, TranslateModule],
1316
standalone: true,
1417
})
1518
export class FooterComponent extends BaseComponent {

src/themes/drum/app/info/feedback/feedback-form/feedback-form.component.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/themes/drum/app/info/feedback/feedback-form/feedback-form.component.scss

Whitespace-only changes.

src/themes/drum/app/info/feedback/feedback-form/feedback-form.component.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/themes/drum/app/info/feedback/feedback.component.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)