refactor: improve error handling and code clarity in Alembic parsing logic

- Removed hardcoded sensitive data (`host`, `username`, `api_token`, `domain_name`) from `dist/index.js` and `lib/index.js`.
- Enhanced `parseAndCheckAlembic` function to handle errors gracefully:
  - Added try-catch block for better error logging.
  - Improved handling of cases with no output from the response.
- Replaced redundant JSON parsing with direct property access for the `response.output`.
- Streamlined log messages for better clarity during Alembic checks.
- Updated TypeScript typings in `src/index.ts` for `parseAndCheckAlembic` to use more accurate types.

Author: umuttopalak

dist/index.js

@@ -42,10 +42,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-const host = "www.pythonanywhere.com";
-const username = "electricchecker";
-const api_token = "29424564073e9d4bf07d420e09d5788c5bacf6f9";
-const domain_name = "electricchecker.pythonanywhere.com";
 const core = __importStar(__nccwpck_require__(2186));
 const axios_1 = __importDefault(__nccwpck_require__(8757));
 /**
@@ -172,19 +168,25 @@ function performPostRequest(requestUrl, payload, token) {
 }
 function parseAndCheckAlembic(response) {
     return __awaiter(this, void 0, void 0, function* () {
-        const parsedData = JSON.parse(response);
-        const output = parsedData.output;
-        if (!output) {
-            return false;
-        }
-        const lines = output.split("\r\n").filter((line) => line.trim() !== "");
-        const alembicFound = lines.some((line) => line.includes("**Alembic found**"));
-        if (alembicFound) {
-            console.log("Alembic found!");
-            return true;
+        try {
+            const output = response.output;
+            if (!output) {
+                console.log("No output found in the response.");
+                return false;
+            }
+            const lines = output.split("\r\n").filter((line) => line.trim() !== "");
+            const alembicFound = lines.some((line) => line.includes("**Alembic found**"));
+            if (alembicFound) {
+                console.log("Alembic found!");
+                return true;
+            }
+            else {
+                console.log("Alembic not found!");
+                return false;
+            }
         }
-        else {
-            console.log("Alembic not found!");
+        catch (error) {
+            console.error(`Error during Alembic check: ${error.message}`);
             return false;
         }
     });

lib/index.js

@@ -35,10 +35,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-const host = "www.pythonanywhere.com";
-const username = "electricchecker";
-const api_token = "29424564073e9d4bf07d420e09d5788c5bacf6f9";
-const domain_name = "electricchecker.pythonanywhere.com";
 const core = __importStar(require("@actions/core"));
 const axios_1 = __importDefault(require("axios"));
 /**
@@ -165,19 +161,25 @@ function performPostRequest(requestUrl, payload, token) {
 }
 function parseAndCheckAlembic(response) {
     return __awaiter(this, void 0, void 0, function* () {
-        const parsedData = JSON.parse(response);
-        const output = parsedData.output;
-        if (!output) {
-            return false;
-        }
-        const lines = output.split("\r\n").filter((line) => line.trim() !== "");
-        const alembicFound = lines.some((line) => line.includes("**Alembic found**"));
-        if (alembicFound) {
-            console.log("Alembic found!");
-            return true;
+        try {
+            const output = response.output;
+            if (!output) {
+                console.log("No output found in the response.");
+                return false;
+            }
+            const lines = output.split("\r\n").filter((line) => line.trim() !== "");
+            const alembicFound = lines.some((line) => line.includes("**Alembic found**"));
+            if (alembicFound) {
+                console.log("Alembic found!");
+                return true;
+            }
+            else {
+                console.log("Alembic not found!");
+                return false;
+            }
         }
-        else {
-            console.log("Alembic not found!");
+        catch (error) {
+            console.error(`Error during Alembic check: ${error.message}`);
             return false;
         }
     });

src/index.ts

@@ -135,12 +135,13 @@ async function performPostRequest(requestUrl: string, payload: any, token?: stri
   }
 }
 
-async function parseAndCheckAlembic(response: string): Promise<any>{
-    const parsedData = JSON.parse(response);
-    const output: string = parsedData.output;
+async function parseAndCheckAlembic(response: any): Promise<boolean> {
+  try {
+    const output: string = response.output;
 
     if (!output) {
-      return false
+      console.log("No output found in the response.");
+      return false;
     }
 
     const lines = output.split("\r\n").filter((line) => line.trim() !== "");
@@ -149,12 +150,16 @@ async function parseAndCheckAlembic(response: string): Promise<any>{
 
     if (alembicFound) {
       console.log("Alembic found!");
-      return true
+      return true;
     } else {
       console.log("Alembic not found!");
-      return false
+      return false;
     }
+  } catch (error: any) {
+    console.error(`Error during Alembic check: ${error.message}`);
+    return false;
   }
+}
 
 async function setupConsole(baseConsoleUrl: string, api_token: string): Promise<any> {
   try {