Merge pull request #33 from umuttopalak/fix/console-type

refactor: improve console setup logic to prioritize valid executables

Author: umuttopalak

dist/index.js

@@ -196,13 +196,13 @@ function setupConsole(baseConsoleUrl, api_token) {
         try {
             const consoleListData = yield performGetRequest(baseConsoleUrl, api_token);
             if (Array.isArray(consoleListData) && consoleListData.length > 0) {
-                const _console = consoleListData.pop();
-                return _console;
-            }
-            else {
-                const _console = yield performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
-                return _console;
+                const validConsole = consoleListData.find(console => console.executable === "bash" || console.executable === "sh");
+                if (validConsole) {
+                    return validConsole;
+                }
             }
+            const newConsole = yield performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
+            return newConsole;
         }
         catch (error) {
             throw new Error(`Failed to setup console: ${error.message}`);

lib/index.js

@@ -189,13 +189,13 @@ function setupConsole(baseConsoleUrl, api_token) {
         try {
             const consoleListData = yield performGetRequest(baseConsoleUrl, api_token);
             if (Array.isArray(consoleListData) && consoleListData.length > 0) {
-                const _console = consoleListData.pop();
-                return _console;
-            }
-            else {
-                const _console = yield performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
-                return _console;
+                const validConsole = consoleListData.find(console => console.executable === "bash" || console.executable === "sh");
+                if (validConsole) {
+                    return validConsole;
+                }
             }
+            const newConsole = yield performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
+            return newConsole;
         }
         catch (error) {
             throw new Error(`Failed to setup console: ${error.message}`);

src/index.ts

@@ -164,12 +164,18 @@ async function setupConsole(baseConsoleUrl: string, api_token: string): Promise<
   try {
     const consoleListData = await performGetRequest(baseConsoleUrl, api_token);
     if (Array.isArray(consoleListData) && consoleListData.length > 0) {
-      const _console = consoleListData.pop();
-      return _console;
-    } else {
-      const _console = await performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
-      return _console;
+      const validConsole = consoleListData.find(console => 
+        console.executable === "bash" || console.executable === "sh"
+      );
+      
+      if (validConsole) {
+        return validConsole;
+      }
     }
+    
+    const newConsole = await performPostRequest(baseConsoleUrl, { executable: "bash" }, api_token);
+    return newConsole;
+    
   } catch (error: any) {
     throw new Error(`Failed to setup console: ${error.message}`);
   }