Skip to content

Fix C++ exception error in Significance 'make style from act. line' stuff function. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moex3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix C++ exception error in Significance 'make style from act. line' stuff function. #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b6b12d
Make boolean types in style a true boolean value.
moex3 Mar 20, 2026
b8f7a5b
Use margins from style if not set on the line.
moex3 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ua.Significance.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,10 +765,10 @@ function stuff(subs,sel,act)
sr.color2="&H"..a2..color2.."&"
sr.color3="&H"..a3..color3.."&"
sr.color4="&H"..a4..color4.."&"
sr.bold=tags:match("\\b([01])") or sr.bold
sr.italic=tags:match("\\i([01])") or sr.italic
sr.underline=tags:match("\\u([01])") or sr.underline
sr.strikeout=tags:match("\\s([01])") or sr.strikeout
sr.bold=makebool(tags:match("\\b([01])") or sr.bold)
sr.italic=makebool(tags:match("\\i([01])") or sr.italic)
sr.underline=makebool(tags:match("\\u([01])") or sr.underline)
sr.strikeout=makebool(tags:match("\\s([01])") or sr.strikeout)
sr.fontname=tags:match("\\fn([^\\}]+)") or sr.fontname
sr.fontsize=tags:match("\\fs(%d+)") or sr.fontsize
sr.scale_x=tags:match("\\fscx([^\\}]+)") or sr.scale_x
Expand All @@ -778,9 +778,9 @@ function stuff(subs,sel,act)
sr.outline=tags:match("\\bord([^\\}]+)") or sr.outline
sr.shadow=tags:match("\\shad([^\\}]+)") or sr.shadow
sr.align=tags:match("\\an(%d)") or sr.align
sr.margin_l=line.margin_l or sr.margin_l
sr.margin_r=line.margin_r or sr.margin_r
sr.margin_t=line.margin_t or sr.margin_t
sr.margin_l=(line.margin_l ~= 0 and line.margin_l) or sr.margin_l
sr.margin_r=(line.margin_r ~= 0 and line.margin_r) or sr.margin_r
sr.margin_t=(line.margin_t ~= 0 and line.margin_t) or sr.margin_t

stylename={{class="label",label="Style Name"},{y=1,class="edit",name="snam",value=""},
{y=2,class="checkbox",name="switch",label="switch to new style",value=true},
Expand Down Expand Up @@ -813,7 +813,7 @@ function stuff(subs,sel,act)
st=subs[i]
if st.name==sr.name then t_error("Style with that name already exists",1) end
end
if subs[i].class=="dialogue" then subs.insert(i,sr)
if subs[i].class=="dialogue" then subs[-i] = sr
for z,s in ipairs(sel) do sel[z]=sel[z]+1 end
break end
end
Expand Down Expand Up @@ -2354,6 +2354,7 @@ end
function loggtab(m) m=tf(m) or "nil" aegisub.log("\n {"..table.concat(m,', ').."}") end
function progress(msg) if aegisub.progress.is_cancelled() then ak() end aegisub.progress.title(msg) end
function t_error(message,cancel) ADD({{class="label",label=message}},{"OK"},{close='OK'}) if cancel then ak() end end
function makebool(val) if type(val) == "string" then return val == "1" else return val end end

function addtag3(tg,txt)
no_tf=txt:gsub("\\t%b()","")
Expand Down