Move to net

Author: pozylon

packages/core/src/directors/BasePricingSheet.ts

@@ -42,17 +42,19 @@ export interface PricingSheetParams<Calculation extends PricingCalculation> {
 export const BasePricingSheet = <Calculation extends PricingCalculation>(
   params: PricingSheetParams<Calculation>,
 ): IBasePricingSheet<Calculation> => {
+  const calculation = params.calculation || [];
+
   const pricingSheet: IBasePricingSheet<Calculation> = {
-    calculation: params.calculation || [],
+    calculation,
     currencyCode: params.currencyCode,
     quantity: params.quantity,
 
     getRawPricingSheet() {
-      return this.calculation;
+      return calculation;
     },
 
     isValid() {
-      return this.calculation.length > 0;
+      return calculation.length > 0;
     },
 
     sum(filter) {
@@ -95,20 +97,20 @@ export const BasePricingSheet = <Calculation extends PricingCalculation>(
             (row: Calculation) =>
               !!row && (filter[filterKey] === undefined || row[filterKey] === filter[filterKey]),
           ),
-        this.calculation,
+        calculation,
       );
 
       return filteredCalculation;
     },
 
     resetCalculation(calculationSheet) {
       calculationSheet.filterBy().forEach(({ amount, ...row }: Calculation) => {
-        this.calculation.push({
+        pricingSheet.calculation.push({
           ...row,
           amount: amount * -1,
         } as Calculation);
       });
-      return this.calculation;
+      return pricingSheet.calculation;
     },
   };
 

packages/core/src/directors/OrderPricingSheet.ts

@@ -94,13 +94,11 @@ export const OrderPricingSheet = (
       });
     },
 
-    gross() {
-      // tax is included 2 times, this is only true for Order Pricing!
-      return basePricingSheet.sum() - this.taxSum();
-    },
-
-    net() {
-      return basePricingSheet.sum() - this.taxSum() - this.taxSum();
+    discountSum(discountId) {
+      return basePricingSheet.sum({
+        category: OrderPricingRowCategory.Discounts,
+        discountId,
+      });
     },
 
     total({ category, useNetPrice, discountId } = { useNetPrice: false }) {

packages/plugins/src/pricing/order-delivery.ts

@@ -32,7 +32,7 @@ export const OrderDelivery: IOrderPricingAdapter = {
           currencyCode: order.currencyCode,
         });
         const tax = pricing.taxSum();
-        const shipping = pricing.gross();
+        const shipping = pricing.net();
 
         pricingAdapter
           .resultSheet()

packages/plugins/src/pricing/order-discount.ts

@@ -99,7 +99,12 @@ export const OrderDiscount: IOrderPricingAdapter<OrderDiscountConfiguration> = {
               Math.max(0, Math.min(amountLeft, leftInFeesToSplit)),
             );
           amountLeft -= deliveryAndPaymentDiscountAmount;
-          const discountAmount = (itemsDiscountAmount + deliveryAndPaymentDiscountAmount) * -1;
+          const discountAmount =
+            (itemsDiscountAmount +
+              deliveryAndPaymentDiscountAmount -
+              itemsTaxAmount -
+              deliveryAndPaymentTaxAmount) *
+            -1;
           const taxAmount = (itemsTaxAmount + deliveryAndPaymentTaxAmount) * -1;
           if (discountAmount) {
             pricingAdapter.resultSheet().addDiscount({

packages/plugins/src/pricing/order-items.ts

@@ -34,7 +34,7 @@ const OrderItems: IOrderPricingAdapter = {
               quantity: orderPosition.quantity,
             });
             const tax = pricing.taxSum();
-            const items = pricing.gross();
+            const items = pricing.net();
             return {
               taxes: current.taxes + tax,
               items: current.items + items,

packages/plugins/src/pricing/order-payment.ts

@@ -33,7 +33,7 @@ const OrderPayment: IOrderPricingAdapter = {
           currencyCode: order.currencyCode,
         });
         const tax = pricing.taxSum();
-        const paymentFees = pricing.gross();
+        const paymentFees = pricing.net();
 
         pricingAdapter
           .resultSheet()

tests/seeds/orders.js

@@ -20,7 +20,8 @@ export const SimpleOrder = {
       category: 'ITEMS',
       amount: 30000,
     },
-    { category: 'TAXES', amount: 2144.8467966573808 },
+    { category: 'ITEMS', amount: -2144.8467966573808 },
+    { category: 'TAXES', amount: 2144.8467966573808, baseCategory: 'ITEMS' },
     {
       category: 'PAYMENT',
       amount: 0,
@@ -115,6 +116,7 @@ export const SimplePosition = {
       isTaxable: false,
       isNetPrice: false,
       rate: 0.077,
+      baseCategory: 'ITEM',
       meta: {
         adapter: 'shop.unchained.pricing.product-swiss-tax',
       },
@@ -214,9 +216,14 @@ export const DiscountedOrder = {
       category: 'ITEMS',
       amount: 100000,
     },
+    {
+      category: 'ITEMS',
+      amount: -7149.489322191272,
+    },
     {
       category: 'TAXES',
       amount: 7149.489322191272,
+      baseCategory: 'ITEMS',
     },
     {
       category: 'PAYMENT',
@@ -231,9 +238,16 @@ export const DiscountedOrder = {
       amount: -10000,
       discountId: 'discounted-order-discount',
     },
+    {
+      category: 'DISCOUNTS',
+      amount: 714.9489322191266,
+      discountId: 'discounted-order-discount',
+    },
     {
       category: 'TAXES',
       amount: -714.9489322191266,
+      baseCategory: 'DISCOUNTS',
+      discountId: 'discounted-order-discount',
     },
   ],
 };
@@ -304,6 +318,7 @@ export const DiscountedPosition = {
       category: 'TAX',
       amount: 8579.387186629523,
       rate: 0.077,
+      baseCategory: 'ITEM',
       meta: {
         adapter: 'shop.unchained.pricing.product-swiss-tax',
       },
@@ -321,6 +336,7 @@ export const DiscountedPosition = {
       category: 'TAX',
       amount: -4289.6935933147615,
       rate: 0.077,
+      baseCategory: 'DISCOUNT',
       meta: {
         adapter: 'shop.unchained.pricing.product-swiss-tax',
       },