feat: Integration with Voicemeeter#745
Conversation
…alled in the system
…ter isn't installed
… feat/voicemeeter-integration Making it so it was impossible to turn it back on
…tegration # Conflicts: # FluentFlyoutWPF/App.xaml.cs
|
Merge conflict has been solved. The formatter is going nuts, as, like I said, Rider is fucking with me, but maybe you can run a formatter with your settings and it should format this properly? |
|
Hi @xlysander12, thank you for looking to contribute. Since there isn't an issue open for this and we don't track usage data, it's hard to gauge how popular or necessary this patch would be for most users so I can't merge it right now. I'll leave this PR open in case we see interest into such a feature - other past PRs have been merged in this way as well! |
|
Hey @unchihugo, it's all good. I've done it because it's useful to me and since I've seen some issues regarding Voicemeeter, albeit not related to the Volume Mixer, I decided I would work on it. Feel free to merge whenever you feel it's an appropriate time |
|
Sounds good. By the way, you're able to run formatting with our codebase's format config by typing dotnet format in the solution's directory! |
Summary
With the new addition of the volume flyout, I've noticed that some users, like myself, who use Voicemeeter to manage their PC audio, the new feature is completely useless as the volume is not controlled by the devices listed in Windows, but in the Voicemeeter app itself.
This PR aims to fix that, adding the possibility to users that have Voicemeeter installed to enable the integration and properly control their volume.
Motivation
Like stated above, this change was made so the volume control would work correctly for users that use Voicemeeter to manage their system audio
Type of Change
What Changed
Volume Flyoutcategory appear calledVoicemeeter IntegrationAdditional Information
Like stated previously, the Voicemeeter Integration settings only appear if Voicemeeter was detected in the system, otherwise, nothing changes at all (I've tested in a computer without Voicemeeter aswell)
When the Integration is enabled, the volume slider adopts and controls the percentage of the Gain slider in Voicemeeter's selected Strip / Bus
DISCLAIMER: I am not, by any means, a C# developer. The usage of AI mentioned below, was purely to get some syntax right as I'm not 100% familiar with it. Besides that, the
Formatting and naming are consistent with the projectoption is not enabled as, for some reason, my IDE (Jetbrains Rider) was putting the braces right after the statements instead of below them and I couldn't fight against itChecklist