Skip to content

feat: add FaultHandlerOverride tlv#38

Draft
Qlas wants to merge 2 commits into
masterfrom
fault-handler-override-tlv
Draft

feat: add FaultHandlerOverride tlv#38
Qlas wants to merge 2 commits into
masterfrom
fault-handler-override-tlv

Conversation

@Qlas
Copy link
Copy Markdown
Collaborator

@Qlas Qlas commented Dec 23, 2024

#37

@Qlas Qlas self-assigned this Dec 23, 2024
@Qlas Qlas added the enhancement New feature or request label Dec 23, 2024
Copy link
Copy Markdown
Owner

@uncommon-nickname uncommon-nickname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/cfdp_core/pdu_tlv.cpp
{
const auto memory_size = memory.size();

if (memory_size < sizeof(uint8_t) + sizeof(uint8_t) + sizeof(uint8_t))
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (memory_size < sizeof(uint8_t) + sizeof(uint8_t) + sizeof(uint8_t))
if (memory_size < 3 * sizeof(uint8_t))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants