Avoid fetching manifest in xdist workers on failure

xdist workers don't have access to the API key and cannot fetch the
manifest. Prior to this change, the xdist worker would attempt to
fetch the manifest if the fetch attempt in the parent process failed.
This change fixes the bug so that xdist workers will never attempt
to fetch the manifest, even if the fetch in the parent process failed.

Author: ramosbugs

src/pytest_unflakable/__init__.py

@@ -159,8 +159,8 @@ def pytest_configure(config: Config) -> None:
     insecure_disable_tls_validation = config.getoption(
         'unflakable_insecure_disable_tls_validation', False)
     manifest = None
-    if is_xdist_worker and 'unflakable_manifest' in config.workerinput:  # type: ignore
-        manifest = config.workerinput['unflakable_manifest']  # type: ignore
+    if is_xdist_worker:
+        manifest = config.workerinput.get('unflakable_manifest')  # type: ignore
         logger.debug(
             f'xdist worker received manifest for test suite {test_suite_id}: '
             f'{pprint.pformat(manifest)}'

src/pytest_unflakable/_plugin.py

@@ -165,8 +165,7 @@ def pytest_configure_node(self, node: Any) -> None:
         """
         nodeid = node.workerinput['workerid']
         self.logger.debug(f'called hook pytest_configure_node: {nodeid}')
-        if self.manifest is not None:
-            node.workerinput['unflakable_manifest'] = self.manifest
+        node.workerinput['unflakable_manifest'] = self.manifest
 
 
 class UnflakablePlugin: