feat: inline admin tab groups#1942
Open
j00bar wants to merge 4 commits into
Open
Conversation
Author
|
Thought: Would you rather have |
j00bar
changed the title
j00bar
changed the title
Contributor
|
hey, first of all thanks for the PR. Before I test the functionality, how much AI did you used? |
Author
I kinda hate that this is a totally fair question in these weird times but it's a fair question. The feature was all coded by me. I used AI to help me understand the organization of and patterns in the test code and to create a first draft of tests, but I edited them after to make them more of what I wanted. The docs were edited by me. |
- Changed app.js to make sure the active tab loads, even if it's a tabgroup - Fixes pagination for inlines on tab groups - Fixed inline_heading.html to show heading when on a tab grouped tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1939
Most of the heavy lifting is done in the
tab_groupstemplatetag function. The logic for deciding the tab element name and tab display title are pulled out of the template and into the templatetag, so that it can be different for tab groups versus solo tabs.Tests are included. Docs are updated.