chore: use oxlint instead of eslint (#503)

Brentlok · web-flow · commit bf79ad8ed979 · 2026-04-21T12:08:44.000+02:00
* chore: use oxlint instead of eslint

* style: oxlint-disable comments
diff --git a/bun.lock b/bun.lock
diff --git a/dprint.json b/dprint.json
@@ -21,6 +21,6 @@
     ],
     "plugins": [
         "https://plugins.dprint.dev/typescript-0.95.15.wasm",
-        "https://plugins.dprint.dev/json-0.19.1.wasm"
+        "https://plugins.dprint.dev/json-0.21.3.wasm"
     ]
 }
diff --git a/package.json b/package.json
@@ -35,11 +35,11 @@
     },
     "devDependencies": {
         "typescript": "catalog:",
-        "dprint": "0.53.0",
-        "eslint": "9.39.1",
-        "eslint-config-codemask": "2.2.1",
+        "dprint": "0.54.0",
+        "oxlint": "1.61.0",
+        "oxlint-tsgolint": "0.21.1",
         "husky": "9.1.7",
-        "turbo": "2.8.20"
+        "turbo": "2.9.6"
     },
     "packageManager": "bun@1.3.10",
     "trustedDependencies": [
diff --git a/packages/uniwind/.oxlintrc.json b/packages/uniwind/.oxlintrc.json
@@ -0,0 +1,29 @@
+{
+    "options": {
+        "typeAware": true
+    },
+    "rules": {
+        "unicorn/no-empty-file": "off",
+        "typescript/strict-boolean-expressions": [
+            "error",
+            {
+                "allowAny": true,
+                "allowNullableBoolean": true,
+                "allowNullableEnum": true
+            }
+        ],
+        "typescript/no-implied-eval": "off"
+    },
+    "ignorePatterns": [
+        "build.config.ts",
+        "types.d.ts",
+        "no-types.d.ts",
+        "src/metro/index.d.ts",
+        "src/vite/index.d.ts",
+        "dist",
+        "specs",
+        "jest.config.js",
+        "tests",
+        "babel.config.cjs"
+    ]
+}
diff --git a/packages/uniwind/eslint.config.ts b/packages/uniwind/eslint.config.ts
diff --git a/packages/uniwind/package.json b/packages/uniwind/package.json
@@ -12,8 +12,8 @@
         "precommit": "bun lint",
         "build": "unbuild",
         "check:typescript": "tsc --noEmit",
-        "lint": "eslint src",
-        "lint:fix": "eslint src --fix",
+        "lint": "oxlint src",
+        "lint:fix": "oxlint src --fix",
         "format": "dprint fmt",
         "prepublishOnly": "bun run build",
         "circular:check": "dpdm --no-warning --no-tree -T --exit-code circular:1 'src/**/*.ts' 'src/**/*.tsx'",
diff --git a/packages/uniwind/src/core/config/config.common.ts b/packages/uniwind/src/core/config/config.common.ts
@@ -5,7 +5,6 @@ import { CSSVariables, GenerateStyleSheetsCallback, ThemeName } from '../types'
 
 const SYSTEM_THEME = 'system' as const
 // Platform.constants is not defined in RNW
-// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
 const RN_VERSION = Platform.constants?.reactNativeVersion?.minor ?? 0
 const UNSPECIFIED_THEME = RN_VERSION >= 82 ? 'unspecified' : undefined
 
@@ -18,7 +17,6 @@ export class UniwindConfigBuilder {
         Appearance.addChangeListener(event => {
             const colorScheme = event.colorScheme === 'unspecified'
                 ? ColorScheme.Light
-                // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
                 : event.colorScheme ?? ColorScheme.Light
             const prevTheme = this.#currentTheme
 
@@ -52,7 +50,7 @@ export class UniwindConfigBuilder {
         return colorScheme ?? ColorScheme.Light
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
+    // oxlint-disable-next-line typescript/no-redundant-type-constituents
     setTheme(theme: ThemeName | typeof SYSTEM_THEME) {
         const prevTheme = this.#currentTheme
         const prevHasAdaptiveThemes = this.#hasAdaptiveThemes
@@ -98,15 +96,12 @@ export class UniwindConfigBuilder {
         }
     }
 
-    updateCSSVariables(theme: ThemeName, variables: CSSVariables) {
+    updateCSSVariables(_: ThemeName, __: CSSVariables) {
         // noop
-        theme
-        variables
     }
 
-    updateInsets(insets: Insets) {
+    updateInsets(_: Insets) {
         // noop
-        insets
     }
 
     protected __reinit(_: GenerateStyleSheetsCallback, themes: Array<string>) {
diff --git a/packages/uniwind/src/core/logger.ts b/packages/uniwind/src/core/logger.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 export class Logger {
     static log(message: string) {
         console.log(`Uniwind - ${message}`)
diff --git a/packages/uniwind/src/core/native/parsers/transforms.ts b/packages/uniwind/src/core/native/parsers/transforms.ts
@@ -1,4 +1,3 @@
-/* eslint-disable max-depth */
 const transforms = [
     'translateX',
     'translateY',
diff --git a/packages/uniwind/src/core/native/store.ts b/packages/uniwind/src/core/native/store.ts
@@ -1,4 +1,3 @@
-/* eslint-disable max-depth */
 import { Dimensions, Platform } from 'react-native'
 import { Platform as UniwindPlatform, UNIWIND_PLATFORM_VARIABLES, UNIWIND_THEME_VARIABLES } from '../../common/consts'
 import { Orientation, StyleDependency } from '../../types'
diff --git a/packages/uniwind/src/core/web/cssListener.ts b/packages/uniwind/src/core/web/cssListener.ts
@@ -54,7 +54,6 @@ class CSSListenerBuilder {
             const mediaQuery = this.classNameMediaQueryListeners.get(className)
 
             if (!mediaQuery) {
-                // eslint-disable-next-line no-empty-function
                 return () => {}
             }
 
@@ -129,7 +128,7 @@ class CSSListenerBuilder {
                 continue
             }
 
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition, @typescript-eslint/strict-boolean-expressions
+            // oxlint-disable-next-line @typescript-eslint/strict-boolean-expressions
             if (!rules) {
                 continue
             }
diff --git a/packages/uniwind/src/hoc/withUniwind.native.tsx b/packages/uniwind/src/hoc/withUniwind.native.tsx
@@ -120,7 +120,6 @@ const withManualUniwind = (Component: Component<AnyObject>, options: Record<Prop
 
         const existingStyle = props[propName]
 
-        // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
         if (existingStyle) {
             acc.generatedProps[propName] = [styles, existingStyle]
 
diff --git a/packages/uniwind/src/metro/addMetaToStylesTemplate.ts b/packages/uniwind/src/metro/addMetaToStylesTemplate.ts
@@ -41,8 +41,7 @@ export const addMetaToStylesTemplate = (Processor: ProcessorBuilder, currentPlat
                     minWidth,
                     maxWidth,
                     colorScheme,
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    important,
+                    important: _,
                     importantProperties,
                     active,
                     focus,
diff --git a/packages/uniwind/src/metro/logger.ts b/packages/uniwind/src/metro/logger.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 const red = '\x1b[91m'
 const yellow = '\x1b[33m'
 const blue = '\x1b[36m'
diff --git a/packages/uniwind/src/metro/metro-css-patches.ts b/packages/uniwind/src/metro/metro-css-patches.ts
@@ -6,7 +6,6 @@ import path from 'path'
 
 class FileStore<T> extends FileStoreBase<T> {
     async set(key: Buffer, value: any): Promise<void> {
-        // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
         if (value?.output?.[0]?.data?.css?.skipCache) {
             return
         }
@@ -27,7 +26,7 @@ interface TraverseDependencies {
 export const patchMetroGraphToSupportUncachedModules = () => {
     const { Graph } = require('metro/private/DeltaBundler/Graph') as typeof import('metro/private/DeltaBundler/Graph')
 
-    // eslint-disable-next-line @typescript-eslint/unbound-method
+    // oxlint-disable-next-line @typescript-eslint/unbound-method
     const original_traverseDependencies = Graph.prototype.traverseDependencies as unknown as TraverseDependencies
 
     if (original_traverseDependencies.__patched) {
diff --git a/packages/uniwind/src/metro/processor/css.ts b/packages/uniwind/src/metro/processor/css.ts
@@ -495,7 +495,6 @@ export class CSS {
         return undefined
     }
 
-    // eslint-disable-next-line @typescript-eslint/member-ordering
     private static readonly TRANSFORM_TYPES = new Set([
         'translate',
         'translateX',
diff --git a/packages/uniwind/src/metro/processor/functions.ts b/packages/uniwind/src/metro/processor/functions.ts
@@ -182,7 +182,6 @@ export class Functions {
                 .replace(/"/g, '')
                 .replace(new RegExp(unit, 'g'), '')
 
-            // eslint-disable-next-line @typescript-eslint/no-implied-eval, no-new-func
             return new Function(`return ${numericValue} + '${unit}'`)()
         } catch {
             this.logger.error(`Invalid calc ${value}`)
diff --git a/packages/uniwind/src/metro/utils/common.ts b/packages/uniwind/src/metro/utils/common.ts
@@ -52,7 +52,6 @@ export const uniq = <T>(arr: Array<T>) => Array.from(new Set(arr))
 
 export const isValidJSValue = (jsValueString: string) => {
     try {
-        // eslint-disable-next-line @typescript-eslint/no-implied-eval, no-new-func
         new Function(`const test = ${jsValueString}`)
 
         return true
diff --git a/packages/uniwind/src/metro/utils/serialize.ts b/packages/uniwind/src/metro/utils/serialize.ts
@@ -103,7 +103,6 @@ export const serializeJSObject = (obj: Record<string, any>, serializer: (key: st
         serializedValues =>
             serializedValues.filter(serializedValue => {
                 try {
-                    // eslint-disable-next-line @typescript-eslint/no-implied-eval, no-new-func
                     new Function(`function validateJS() { const obj = ({ ${serializedValue} }) }`)
 
                     return true
diff --git a/packages/uniwind/src/types.ts b/packages/uniwind/src/types.ts
@@ -20,5 +20,4 @@ export const enum ColorScheme {
     Dark = 'dark',
 }
 
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface UniwindConfig {}

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,6 @@`
`21`	`21`	`],`
`22`	`22`	`"plugins": [`
`23`	`23`	`"https://plugins.dprint.dev/typescript-0.95.15.wasm",`
`24`		`- "https://plugins.dprint.dev/json-0.19.1.wasm"`
	`24`	`+ "https://plugins.dprint.dev/json-0.21.3.wasm"`
`25`	`25`	`]`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-/* eslint-disable no-console */`
`2`		`-`
`3`	`1`	`export class Logger {`
`4`	`2`	`static log(message: string) {`
`5`	`3`	console.log(`Uniwind - ${message}`)
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* eslint-disable max-depth */`
`2`	`1`	`const transforms = [`
`3`	`2`	`'translateX',`
`4`	`3`	`'translateY',`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-/* eslint-disable max-depth */`
`2`	`1`	`import { Dimensions, Platform } from 'react-native'`
`3`	`2`	`import { Platform as UniwindPlatform, UNIWIND_PLATFORM_VARIABLES, UNIWIND_THEME_VARIABLES } from '../../common/consts'`
`4`	`3`	`import { Orientation, StyleDependency } from '../../types'`