Conversation
📝 WalkthroughWalkthroughThis PR updates the Uniwind skill documentation to reflect version 1.6.0+, new animation features (Reanimated entering/exiting and layout transitions), Display P3 color support, graduated Pro pricing tiers, updated API usage patterns for theme transitions, and new built-in utility classes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/uniwind/SKILL.md`:
- Line 1824: The docs show Uniwind.setTheme being called with a second
transition options argument (e.g., Uniwind.setTheme('dark', { preset:
ThemeTransitionPreset.Fade })) but the real API (setTheme in config.common.ts)
only accepts one parameter, causing TS/runtime errors; fix by either updating
the documentation to remove the second argument and explicitly state that theme
transitions are not accepted by Uniwind.setTheme, or implement an
overloaded/extended API in the core by adding a second parameter (e.g.,
ThemeTransitionOptions) to setTheme (and its type/enum like
ThemeTransitionPreset) and wire the transition logic in setTheme so both docs
and implementation match. Ensure references to Uniwind.setTheme, setTheme,
ThemeTransitionPreset (and ThemeTransitionOptions if you add it) are updated
consistently.
- Around line 1689-1695: The docs claim auto-swapping for Text, TextInput, and
Pressable but the code shows Animated exports in
packages/uniwind/src/components/web/Animated.tsx only expose View, Text, Image,
ScrollView, FlatList, SectionList and native Text in
packages/uniwind/src/components/native/Text.tsx wraps RNText (not
Animated.Text), so fix by either (A) making implementation match docs: add
wrappers/exports for Animated.TextInput and Animated.Pressable in Animated.tsx
and change Text.tsx to wrap/forward to Animated.Text (ensure TextInput/Pressable
use Animated equivalents and update any related prop forwarding), or (B) update
SKILL.md to remove/adjust the auto-swap claims and list only the actually
supported components (match the export list from Animated.tsx and note that
native Text does not auto-wrap). Choose one approach and apply it consistently
across SKILL.md and the component files (reference Animated.tsx, Text.tsx,
TextInput, Pressable, and SKILL.md).
- Around line 999-1016: The "Display P3 Colors support" documentation block
incorrectly claims Uniwind parses and converts color(display-p3 ...) values;
either remove this block entirely or change it to clearly state the feature is
not implemented (e.g., mark as "planned" or "experimental") and/or link to the
tracking issue. Locate the "Display P3 Colors support" header and the CSS
example containing the literal text "color(display-p3" in SKILL.md and update
the text accordingly so it does not assert existing functionality.
- Around line 27-29: The SKILL.md header claiming "Uniwind 1.6.0+" conflicts
with the package version "1.4.1" in package.json; fix by aligning the docs and
release state: either change the SKILL.md header and any references to "1.6.0+"
and described features (e.g., "Display P3 colors", "new animations", "updated
APIs") to "1.4.1" and remove unreleased feature claims, or explicitly mark the
document as "unreleased / upcoming" and add a clear note that features are for a
future 1.6.0 release (and ensure a corresponding git tag/release is created if
you intend to ship 1.6.0). Also update any install instructions referencing
version 1.6.0 so they point to the actual "1.4.1" package or to a prerelease
tag.
- Around line 1854-1856: The docs list
ThemeTransitionPreset.Blur/BlurRightToLeft/BlurLeftToRight which aren’t
implemented; either remove those rows from SKILL.md or implement the presets and
wiring: add a ThemeTransitionPreset enum (with Blur, BlurRightToLeft,
BlurLeftToRight), export it, extend the setTheme function signature to accept an
optional preset parameter and options, implement handling in the theme
application code to map those presets to actual transition behavior, and update
any exports so ThemeTransitionPreset is available to consumers; choose one
approach and make the corresponding change and tests/docs consistent.
- Around line 1697-1738: The "Entering & Exiting Animations" documentation
falsely advertises uw-entering-*, uw-exiting-* class handlers, animation
modifiers, and an auto-upgrade mechanism that don't exist; remove this entire
section from SKILL.md and any references to these presets and modifiers, and
instead add a short note directing users to implemented animation features (or
mark as planned). Search for the documented symbols (uw-entering-*,
uw-exiting-*, uw-layout-*, and mentions of withUniwind HOC/auto-upgrade) in the
markdown and delete the whole block describing presets, modifiers, and examples
so docs match the current codebase.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
🚀 This pull request is included in v1.6.3. See Release v1.6.3 for release notes. |
Summary by CodeRabbit
New Features
border-continuousandborder-circularclassesDocumentation
Pro Updates