fix: inject cjs instead of esm to initialize#501
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single-line modification in the metro transformer's non-web CSS transformation path, replacing an ES module import statement with a CommonJS require destructuring pattern for compatibility with tree-shaking-enabled build environments. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 This pull request is included in v1.6.3. See Release v1.6.3 for release notes. |
Fixes #500
In debug mode / without tree shaking metro was converting all files to CJS.
It doesn't do this in optimized, tree shaking build so it caused error.
Common JS is correct format on native
Summary by CodeRabbit