Skip to content

chore: update config attributes and lint rules#504

Merged
Brentlok merged 1 commit intomainfrom
corrections
Apr 21, 2026
Merged

chore: update config attributes and lint rules#504
Brentlok merged 1 commit intomainfrom
corrections

Conversation

@Brentlok
Copy link
Copy Markdown
Contributor

@Brentlok Brentlok commented Apr 21, 2026

Summary by CodeRabbit

  • Chores
    • Updated ESLint configuration settings.
    • Improved internal code naming conventions.

@Brentlok Brentlok merged commit 00df11b into main Apr 21, 2026
1 check passed
@Brentlok Brentlok deleted the corrections branch April 21, 2026 10:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12aeb29f-d294-46e3-8e1e-271282b08c00

📥 Commits

Reviewing files that changed from the base of the PR and between bf79ad8 and 30e8168.

📒 Files selected for processing (2)
  • packages/uniwind/.oxlintrc.json
  • packages/uniwind/src/core/config/config.common.ts

📝 Walkthrough

Walkthrough

Configuration rules and method parameters were updated. A TypeScript linting rule for strict boolean expressions was disabled entirely, and method parameter names in a configuration builder were changed from unused placeholders to descriptive names with accompanying lint suppressions.

Changes

Cohort / File(s) Summary
Linting Configuration
packages/uniwind/.oxlintrc.json
Disabled the typescript/strict-boolean-expressions ESLint rule by changing it from "error" with allowances to "off" severity.
Configuration Builder Methods
packages/uniwind/src/core/config/config.common.ts
Updated UniwindConfigBuilder method parameters from unused placeholders (_, __) to named parameters (theme, cssVariables, insets) with added lint suppressions for unused variables and redundant type constituents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 Placeholders fade, true names take their place,
Parameters now speak with clarity and grace,
Lint rules relax, the builder stands tall,
Named with intent—no confusion at all! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch corrections

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🚀 This pull request is included in v1.6.3. See Release v1.6.3 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant