Skip to content

Commit 4589a3f

Browse files
committed
chore(spec-11): annotate smoke test checklist items as pending CI and fix Results section
All checklist items require a live marketplace URL; annotate each one with 'pending CI — requires live marketplace URL' and correct the Results section to accurately reflect that no items were executed locally.
1 parent 5635ed0 commit 4589a3f

2 files changed

Lines changed: 19 additions & 19 deletions

File tree

docs/plans/11-smoke-tests.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ cat docs/process/smoke-test-checklist.md # file exists and is non-empty
102102
Executed on macOS 2026-04-29.
103103

104104
**Passed (local):**
105-
- `docs/process/smoke-test-checklist.md` created with all required sections (marketplace setup, auto-format, pr-review, confluence-publish, cleanup).
105+
- None. No checklist items could be executed locally because all items require a live marketplace URL (the GitHub repo must be published first).
106106

107107
**Pending CI / pending live environment:**
108-
- All marketplace and plugin install/run/uninstall items require the GitHub repo to be live (for a real marketplace URL) and the corresponding live services (Azure DevOps, Confluence). These will be validated when spec 12 cuts the first releases and the repo is published.
108+
- All checklist items are annotated "pending CI — requires live marketplace URL" in `docs/process/smoke-test-checklist.md`. Every marketplace, install, run, and uninstall step depends on the GitHub repo being live (spec 12). Windows items additionally require the CI matrix runner. These will be validated when spec 12 cuts the first releases and publishes the repo.
109109

110-
**Issues found:** None. The checklist file is well-formed and covers all three plugins.
110+
**Issues found:** None. The checklist file is well-formed and covers all three plugins. All items are annotated with their blocking dependency.

docs/process/smoke-test-checklist.md

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,31 +11,31 @@ Run these tests from a scratch Claude Code environment (a consumer repo that doe
1111

1212
## Marketplace setup
1313

14-
- [ ] `claude marketplace add <unic-agents-plugins-url>` succeeds
15-
- [ ] `claude plugins list` shows `pr-review`, `auto-format`, `confluence-publish`
14+
- [ ] `claude marketplace add <unic-agents-plugins-url>` succeeds — pending CI — requires live marketplace URL
15+
- [ ] `claude plugins list` shows `pr-review`, `auto-format`, `confluence-publish` — pending CI — requires live marketplace URL
1616

1717
## auto-format
1818

19-
- [ ] `claude plugins install auto-format` succeeds
20-
- [ ] Open a consumer project in Claude Code
21-
- [ ] Ask Claude to edit a JavaScript file — verify Prettier runs automatically after the edit
22-
- [ ] Ask Claude to edit a file with ESLint violations — verify ESLint runs
23-
- [ ] On Windows: repeat the above (via CI matrix in `.github/workflows/ci.yml`)
19+
- [ ] `claude plugins install auto-format` succeeds — pending CI — requires live marketplace URL
20+
- [ ] Open a consumer project in Claude Code — pending CI — requires live marketplace URL
21+
- [ ] Ask Claude to edit a JavaScript file — verify Prettier runs automatically after the edit — pending CI — requires live marketplace URL
22+
- [ ] Ask Claude to edit a file with ESLint violations — verify ESLint runs — pending CI — requires live marketplace URL
23+
- [ ] On Windows: repeat the above (via CI matrix in `.github/workflows/ci.yml`) — pending CI — requires live marketplace URL and Windows runner
2424

2525
## pr-review
2626

27-
- [ ] `claude plugins install pr-review` succeeds
28-
- [ ] Run `/pr-review` with a valid Azure DevOps PR URL
29-
- [ ] Verify a review comment is produced
27+
- [ ] `claude plugins install pr-review` succeeds — pending CI — requires live marketplace URL
28+
- [ ] Run `/pr-review` with a valid Azure DevOps PR URL — pending CI — requires live marketplace URL and Azure DevOps
29+
- [ ] Verify a review comment is produced — pending CI — requires live marketplace URL and Azure DevOps
3030

3131
## confluence-publish
3232

33-
- [ ] `claude plugins install confluence-publish` succeeds
34-
- [ ] Run `/confluence-publish` with a test Markdown file and a valid page ID
35-
- [ ] Verify the Confluence page is updated
33+
- [ ] `claude plugins install confluence-publish` succeeds — pending CI — requires live marketplace URL
34+
- [ ] Run `/confluence-publish` with a test Markdown file and a valid page ID — pending CI — requires live marketplace URL and Confluence instance
35+
- [ ] Verify the Confluence page is updated — pending CI — requires live marketplace URL and Confluence instance
3636

3737
## Cleanup
3838

39-
- [ ] `claude plugins uninstall auto-format` succeeds
40-
- [ ] `claude plugins uninstall pr-review` succeeds
41-
- [ ] `claude plugins uninstall confluence-publish` succeeds
39+
- [ ] `claude plugins uninstall auto-format` succeeds — pending CI — requires live marketplace URL
40+
- [ ] `claude plugins uninstall pr-review` succeeds — pending CI — requires live marketplace URL
41+
- [ ] `claude plugins uninstall confluence-publish` succeeds — pending CI — requires live marketplace URL

0 commit comments

Comments
 (0)