ICU-23413 Fix null pointer dereference in RuleBasedNumberFormat::getRuleSetDisplayName#4006
Open
UnLucky252 wants to merge 1 commit into
Open
ICU-23413 Fix null pointer dereference in RuleBasedNumberFormat::getRuleSetDisplayName#4006UnLucky252 wants to merge 1 commit into
UnLucky252 wants to merge 1 commit into
Conversation
…uleSetDisplayName localeName.getBuffer(len + 1) can return NULL on allocation failure (or when the string is bogus). The result was indexed via localeStr[len] = 0 in the following loop without a NULL check, which is undefined behavior on OOM. Return a bogus UnicodeString when getBuffer returns NULL. Found by static analysis (Svace, ISP RAS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Jira issue
ICU-23413
Summary
In
RuleBasedNumberFormat::getRuleSetDisplayName(icu4c/source/i18n/rbnf.cpp),the result of
localeName.getBuffer(len + 1)was indexed vialocaleStr[len] = 0in the following loop without a NULL check.Cause
UnicodeString::getBuffer(int32_t)returns NULL on allocation failure(or when the string is bogus); the indexed write is then undefined
behavior.
Fix
Return a bogus
UnicodeStringwhengetBufferreturns NULL.Testing
Existing tests pass (no behavior change on the success path). No new
test added — the OOM path requires allocator injection that is not
part of the standard test harness.
Notes
Found by static analysis (Svace, ISP RAS).
Checklist