ICU-23364 Add support of the new dayOfMonths CLDR resources (and the "ddd" pattern symbol) to ICU#4010
ICU-23364 Add support of the new dayOfMonths CLDR resources (and the "ddd" pattern symbol) to ICU#4010richgillam wants to merge 15 commits into
Conversation
…ate en.txt and root.txt to correspond to CLDR changes.
…ting and setting the day-of-month names. Added an appropriate unit test.
…n appropriate unit test.
…d added a unit test.
…nd add unit tests.
…d by the code review bot.
…emporary changes made on the C++ side.
…ng unit tests into Java.
|
NOTE TO SELF: In addition to the current failing tests in Java (which seem to be because I screwed up the Java data generation process and accidentally deleted some key files), I'm also getting reports that the Java code fails on skeletons that include |
…ommmit. Fixed a bug in the way DateTimePatternGenerator handled "dd" skeletons in Java and added appropriate unit tests for the "dd" problem. This reverts commit 54b90d7.
I think I've fixed this now... |
macchiati
left a comment
There was a problem hiding this comment.
Java looks good; my C++ skills are too rusty for that part.
…c API (and for those that weren't needed by SimpleDateFormat, removed them altogether). Removed the unit tests for the new methods on DateFormatSymbols. Renamed getDayOfMonthTypeNames() to getDayOfMonthCardinalNames() in an effort to improve clarity.
This PR adds support in ICU for the new
daysOfMonthsresources introduced to CLDR by https://unicode-org.atlassian.net/browse/CLDR-7408. It includes:dddpattern/skeleton sequence inSimpleDateFormat(both formatting and parsing) andDateTimePatternGenerator.This PR is large; I split it into 10 separate commits to make it easier to review.
A few issues worth calling out:
dayOfMonthsstuff), but this lets us test the implementation in advance of the next CLDR integration landing..resfiles, and I think I may have accidentally picked up some stray changes we don't want. I think we lost a few files we want to keep, and there are a couple stray unit-test changes unrelated to the work of this PR that I think happened because we picked up extraneous changes in the Java ICU data. I'm assuming (hoping?) this will all get straightened out in the next CLDR integration.<dayOfMonth type="x">resources right now because nothing in the CLDR change uses them. I have tested these resources in Apple ICU on changes that aren't in CLDR-7408. I made two CLDR changes in Apple CLDR that we don't have in open-source CLDR: 1) Support for ordinals (i.e., just "1er") in French, and 2) replacement of the "hanidays" numbering system with equivalentdayOfMonthsresources. I can file tickets to add these things to CLDR and add appropriate unit tests for them to ICU. (As I said, I have all that in Apple ICU, so the relevant code here has been tested.)Checklist