🚧 ICU-23424 MF2: Allow registered functions to override standards#4038
Closed
srl295 wants to merge 2 commits into
Closed
🚧 ICU-23424 MF2: Allow registered functions to override standards#4038srl295 wants to merge 2 commits into
srl295 wants to merge 2 commits into
Conversation
- includes marked TODOs where API was insufficient
srl295
changed the title
srl295
commented
Jun 24, 2026
Comment on lines
283
to
+293
|
|
||
| if (isBuiltInFunction(functionName)) { | ||
| return standardMFFunctionRegistry.getFunction(functionName); | ||
| } | ||
| if (hasCustomMFFunctionRegistry()) { | ||
| const MFFunctionRegistry& customMFFunctionRegistry = getCustomMFFunctionRegistry(); | ||
| Function* function = customMFFunctionRegistry.getFunction(functionName); | ||
| if (function != nullptr) { | ||
| return function; | ||
| } | ||
| } | ||
| if (isBuiltInFunction(functionName)) { | ||
| return standardMFFunctionRegistry.getFunction(functionName); | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the only strictly necessary change, for overriding.
| UnicodeString id; | ||
|
|
||
| public: // TODO ICU-23424 had to make this public so FunctionContext is constructable | ||
| FunctionContext(const Locale& loc, UMFBidiOption d, UnicodeString i) |
Contributor
There was a problem hiding this comment.
Rather than making the constructor public, I would prefer to add a public method that takes a FunctionContext and returns a new FunctionContext with a different locale, like:
FunctionContext withLocale(const Locale& loc)
because I don't see a use case for custom functions creating a FunctionContext with a different directionality or ID.
catamorphism
requested changes
Jun 24, 2026
6 tasks
Member
Author
|
See #4041 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate to PR #4021
For discussion.
allows registered functions to override standard ones
add a test for overriding standard functions
A number of "TODO ICU-23424" mark places where the API was insufficient for overriding:
const MFFunctionRegistry& getDefaultFunctionRegistry()where I could callgetFunction("date")… etcFunctionContext. Add a builder for it.Note: seems this fails on Windows due to linkage.
Checklist