ICU-23429 MessageFormat: Implement currency formatting#4040
Open
catamorphism wants to merge 1 commit into
Open
ICU-23429 MessageFormat: Implement currency formatting#4040catamorphism wants to merge 1 commit into
catamorphism wants to merge 1 commit into
Conversation
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Implement currency formatting according to the spec for Unicode MessageFormat.
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
7 tasks
srl295
reviewed
Jun 26, 2026
| opts = options.mergeOptions(arg.getResolvedOptions(), errorCode); | ||
| innerValue = arg.unwrap(); | ||
| functionName = UnicodeString(parent.isInteger ? "integer" : "number"); | ||
| functionName = u"number"; |
| functionName = u"integer"; | ||
| break; | ||
| case NumberType::kCurrency: | ||
| functionName = u"currency"; |
Member
There was a problem hiding this comment.
Suggested change
| functionName = u"currency"; | |
| functionName = options::CURRENCY; |
srl295
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement currency formatting according to the spec for Unicode MessageFormat.
Checklist