ICU-23424 C: MF2: Allow overriding standard functions#4041
Open
srl295 wants to merge 1 commit into
Open
Conversation
srl295
changed the title
srl295
added a commit
to srl295/icu
that referenced
this pull request
Jun 25, 2026
srl295
force-pushed
the
icu-23424/allow-function-override-2
branch
from
463d821 to
5d82d17
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
7 tasks
7 tasks
mihnita
previously approved these changes
Jul 1, 2026
mihnita
left a comment
mihnita
left a comment
Contributor
There was a problem hiding this comment.
LGTM from the "I think that it does the right thing based on what we agreed in TC" point of view.
That is without knowing the code, and with my somewhat rusty C++.
Please wait for a review from Tim to submit.
- tests included - update API docs to indicate that overriding is allowed See unicode-org#4041
srl295
force-pushed
the
icu-23424/allow-function-override-2
branch
from
5d82d17 to
931551a
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4038 and #4021
Checklist