ICU-23450 Fix undefined shift and buffer overflow in ubidi_writeReordered#4060
Open
FrankYFTang wants to merge 1 commit into
Open
ICU-23450 Fix undefined shift and buffer overflow in ubidi_writeReordered#4060FrankYFTang wants to merge 1 commit into
FrankYFTang wants to merge 1 commit into
Conversation
a5d9c73 to
e10e86e
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ubidi_writeReordered, if mirroring was enabled and a characterexpanded during mirroring (e.g. U+221D mirrors to U+1DB10, expanding
from 1 to 2 UTF-16 code units),
doWriteForwardreturned the expandedlength.
ubidi_writeReorderedthen used this expanded length to indexdirPropsat line 651, leading to out-of-bounds read and undefined shift.This CL fixes this by:
dirPropsinubidi_writeReordered.doWriteForward(mirroring and default cases) anddoWriteReverse(default case) to correctly check destination buffer capacity during
write, accounting for mirroring expansion, and perform correct preflighting.
doWriteReversewhere copying of combiningcharacters was using incorrect index due to assuming mirrored character
has same length as original.
Adds unit tests to
cintltstverifying the fixes.Also add Java unit test and fix the java.
Checklist