Implement placeholder extraction for icu_pattern#8074

Open

sffc wants to merge 25 commits into

unicode-org:mainfrom

sffc:feature/pattern-extraction

Commits on Jun 12, 2026

🤖 Implement placeholder extraction for Pattern

sffc
and
gemini-code-assist[bot]
committed
🤖 Address feedback: rename to extract_placeholders, implement get generically, gate MultiNamed matches

sffc
and
gemini-code-assist[bot]
committed
🤖 Refactor extraction to use generic Pattern<B> with ExtractionBackend bound

sffc
and
gemini-code-assist[bot]
committed
🤖 Remove MultiNamedPlaceholder extraction implementation and clean up unused imports

sffc
and
gemini-code-assist[bot]
committed
🤖 Move extraction code to the bottom of frontend/mod.rs, just above tests

sffc
and
gemini-code-assist[bot]
committed
🤖 Move ExtractionBackend trait to the bottom of common.rs

sffc
and
gemini-code-assist[bot]
committed
🤖 Scope match_double as local function match_double_recurse inside extract

sffc
and
gemini-code-assist[bot]
committed
🤖 Add doc tests for extract_placeholders and PlaceholderMatches::get

sffc
and
gemini-code-assist[bot]
committed
🤖 Make integration tests much more thorough with edge cases and backtracking tests

sffc
and
gemini-code-assist[bot]
committed
🤖 Simplify Single and Double placeholder extraction to be non-recursive and highly optimized

sffc
and
gemini-code-assist[bot]
committed
🤖 Refactor DoublePlaceholder extraction to use iter_items and slice pattern matching

sffc
and
gemini-code-assist[bot]
committed
Refactor DoublePlaceholder extraction to use clean iterative decomposition
sffc
committed
Simplify prefix and suffix stripping using strip_prefix and strip_suffix
sffc
committed
Refactor DoublePlaceholder extraction to use clean Option matching for infix
sffc
committed
Refactor DoublePlaceholder extraction to use split_at_checked and safe mutable references
sffc
committed
Simplify 2-placeholders matching using split_once
sffc
committed
Rename 2-placeholders variables to X and Y for clarity
sffc
committed
Refactor SinglePlaceholder extraction to use clean iterative decomposition, consistent with DoublePlaceholder
sffc
committed
Refactor SinglePlaceholder and DoublePlaceholder extraction with clean comments and inlined unwraps
sffc
committed

Commits on Jun 16, 2026

Commits on Jun 17, 2026

🤖 Fix doc warnings by escaping square brackets in [Unstable]

sffc
and
gemini-code-assist[bot]
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement placeholder extraction for icu_pattern#8074

Implement placeholder extraction for icu_pattern#8074
sffc wants to merge 25 commits into
unicode-org:mainfrom
sffc:feature/pattern-extraction

Commits on Jun 12, 2026

🤖 Implement placeholder extraction for Pattern

🤖 Address feedback: rename to extract_placeholders, implement get generically, gate MultiNamed matches

🤖 Refactor extraction to use generic Pattern<B> with ExtractionBackend bound

🤖 Remove MultiNamedPlaceholder extraction implementation and clean up unused imports

🤖 Move extraction code to the bottom of frontend/mod.rs, just above tests

🤖 Move ExtractionBackend trait to the bottom of common.rs

🤖 Scope match_double as local function match_double_recurse inside extract

🤖 Add doc tests for extract_placeholders and PlaceholderMatches::get

🤖 Make integration tests much more thorough with edge cases and backtracking tests

🤖 Simplify Single and Double placeholder extraction to be non-recursive and highly optimized

🤖 Refactor DoublePlaceholder extraction to use iter_items and slice pattern matching

Refactor DoublePlaceholder extraction to use clean iterative decomposition

Simplify prefix and suffix stripping using strip_prefix and strip_suffix

Refactor DoublePlaceholder extraction to use clean Option matching for infix

Refactor DoublePlaceholder extraction to use split_at_checked and safe mutable references

Simplify 2-placeholders matching using split_once

Rename 2-placeholders variables to X and Y for clarity

Refactor SinglePlaceholder extraction to use clean iterative decomposition, consistent with DoublePlaceholder

Refactor SinglePlaceholder and DoublePlaceholder extraction with clean comments and inlined unwraps

Commits on Jun 16, 2026

🤖 Rename extract_placeholders to extract_values

🤖 Address code review feedback: prefix internal ExtractionBackend items with internal_

🤖 Expose ExtractionBackend items in docs with unstable warning banners

🤖 Rename ExtractionBackend internal items to use _unstable suffix

🤖 Prefix ExtractionBackend unstable items with 🚧 [Unstable] in docs

Commits on Jun 17, 2026

🤖 Fix doc warnings by escaping square brackets in [Unstable]