Introduce dedicated LanguageIdentifierDisplayNameOptions struct#8135
Conversation
…ions struct - Add `LanguageIdentifierDisplayNameOptions` with only the `language_display` option to `options.rs`. - Re-export it in `displaynames/mod.rs`. - Refactor `LanguageIdentifierDisplayNameOwned` to use `LanguageIdentifierDisplayNameOptions` instead of `DisplayNamesOptions`. - Update docstring examples and integration tests in `tests.rs` to use the new options struct. - Update `single/README.md` design documentation and add an open question about moving dialect names to a separate data marker. Co-authored-by: Gemini <176961590+gemini-code-assist[bot]@users.noreply.github.com>
9305df1 to
4898099
Compare
|
I pity the person who will have to consolidate all those AI-generated changelog entries. Is it necessary to list the fields of new types? And the methods it listed as new are not new. |
|
When we discussed the changelog rules we explicitly agreed to not include methods, fields, etc on new types, and that exception is in our policy. I edited the changelog entry. I did find that the PR body in #8132 had a much less "density of usefulness" than I typically get from sffc PRs. It still had everything I wanted so I didn't complain. |
|
The agent wrote both the PR description and the changelog entry. I could have slimmed down the PR description but figured it wasn't a good use of my time (perhaps for a similar reason as @robertbastian sometimes doesn't include enough detail in the PR description). I probably should have slimmed down the changelog entry. |
This pull request is part of the implementation for the main locale display names tracking issue: #7825.
This pull request introduces a dedicated options bag
LanguageIdentifierDisplayNameOptionsspecifically for the single formatterLanguageIdentifierDisplayNameOwned(and its borrowed version).Previously, the single formatter reused the general
DisplayNamesOptionsbag, which contains options likestylethat are only supported by the multi-formatters (since single formatters are currently hardcoded to theMediumwidth data markers).By introducing a dedicated options bag, we:
language_display/ dialect resolution).style.All docstring examples, constructors, and integration tests have been updated to use the new options bag.
🤖 This pull request was created by an AI agent working with @sffc.
Changelog
icu_experimental: Introduce dedicated
LanguageIdentifierDisplayNameOptionsstructLanguageIdentifierDisplayNameOptions