Feat/g1 23dof#691
Open
Kennyp-Chen wants to merge 13 commits into
Open
Conversation
Collaborator
|
@LeeLeno 把npz文件上传至huggingface,并清除、覆盖npz文件提交历史。 |
LeeLeno
reviewed
Jul 9, 2026
Collaborator
|
请自查(包括但不限于)src/unilab/envs/motion_tracking路径下脚本加载数据集路径有误/漏传数据集 @Kennyp-Chen |
Author
@LeeLeno 已自查完成: ✅ 已删除误传的 AMP motion 文件夹(23dof_amp/Recovery/、23dof_amp/WalkandRun/) 后续 HF 上传 + git 历史清理辛苦处理~ 谢谢! |
Kennyp-Chen
force-pushed
the
feat/g1-23dof
branch
from
July 9, 2026 09:42
7bd6350 to
d4fb352
Compare
…ort-prone Jacobian test Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
… backend Two-part fix for the G1 23-DoF box_tracking ValueError 'operands could not be broadcast together with shapes (N,16) (23,)': 1. BoxMotionLoader fallback: remove erroneous '-7' from n_robot_joints calc when joint_names is absent. 23-DoF motion data joint_pos is pure robot joints (23) without floating base, so subtracting 7 truncated to 16. 2. MotrixBackend get_dof_pos/get_dof_vel: use actuator-level joint indices (_actuator_joint_pos/vel_indices) instead of body.get_joint_dof_pos/vel() which returned wrong dim for 23-DoF model. Also includes pre-existing uncommitted updates: - Register motrix backend for G1Walk23DofFlat/Rough and G1WBTObs23Dof - Add pose_weights to g1_23dof_walk_flat motrix config - Update support matrix (23-DoF tasks marked Tested/Registered for motrix) - Add g1_23dof_walk_rough mujoco config - Ignore .sisyphus/ directory
- Remove G1_23DOF_INIT.md from tracking (internal doc, now gitignored) - Ignore internal docs: G1_23DOF_INIT.md, G1_23DOF_PR_CHECKLIST.md, APPO_HARDWARE_TIMING_ANALYSIS.md - Add conf/offpolicy/task/flashsac/g1_23dof_walk_flat/motrix.yaml (FlashSAC 23-DoF motrix config, trained and verified)
- Run generate_support_matrix.py to update 23-DoF support status - Ignore log/ directory (training checkpoints/ONNX exports)
The 18 g1 23-DoF AMP motion clips under motions/g1/23dof_amp/ are now hosted on the unilabsim/unilab-motions HF dataset and pulled on demand, mirroring how g1/x2 motions and x2 meshes are already handled. Their blobs are purged from this branch's history; .gitignore is extended to cover nested motion subdirectories so they cannot be re-committed, and .gitkeep placeholders preserve the directory layout for HF downloads. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Wrap long assert message to satisfy repo ruff line-length config. Cherry-picked script from fork was authored against a looser style.
Kennyp-Chen
force-pushed
the
feat/g1-23dof
branch
from
July 14, 2026 03:09
31454f4 to
4796258
Compare
Author
后续可以从 #691 进行合并,感谢你的工作! |
TATP-233
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
为 G1 机器人添加完整的 23-DoF(23 自由度)支持,覆盖所有算法和后端。
g1_23dof_*系列 task,可通过task=<task>/<backend>直接使用;support matrix 已更新Linked Work
Validation
make check— formatting and type check passeduv run pytest -m "not slow"— passed (all fast tests)Commands actually run:
Impact
mujoco/motrixArtifacts
Checklist
新增内容
任务配置
环境代码
tracking.py/flip_tracking.py/box_tracking.py— 23-DoF 环境子类,带球形手观测过滤tracking_obs.py— WBT 观测支持joystick.py— 23-DoF 摇杆 locomotion 环境场景资产
g1_23dof_sphere_hand.xml— 球形手机器人描述文件实现要点
backend.pyMotrix 适配:补充_actuator_joint_vel_indices计算,对多自由度关节(如 Stewart 平台)做降级处理,保障 box_tracking 等任务在 Motrix 后端正常运行g1_walk_23dof_motion.npy和g1_stand_23dof_motion.npy到加载列表已知问题
以下 6 个任务/后端组合在 RTX 5090 上训练失败(最终策略未能成功执行动作):
g1_23dof_flip_tracking(motrix)g1_23dof_flip_tracking(mujoco)g1_23dof_wall_flip_tracking(mujoco)g1_23dof_flip_tracking(motrix)g1_23dof_wall_flip_tracking(motrix)g1_23dof_motion_tracking(mujoco)已与 UniLab 的一位作者确认,以上问题在所有 G1 变体(含上游 29-DoF)上均能复现,与本次 23-DoF 改动无关。Reviewer 可选:
验证(详细)
make check: formatting + type check passeduv run pytest -m "not slow": all fast tests passedmake test-all: 1458 passed,13 skipped,0 failures文档