Skip to content

Commit cf7a2f5

Browse files
committed
Accept bare host for http proxy
1 parent c3a8cf2 commit cf7a2f5

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

app/Env.hs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import Share.Utils.Servant.Cookies qualified as Cookies
2424
import Share.Web.Authentication (cookieSessionTTL)
2525
import Hasql.Pool qualified as Pool
2626
import Hasql.Pool.Config qualified as Pool
27-
import Network.URI (parseURI, uriScheme)
27+
import Network.URI (parseURI)
2828
import Servant.API qualified as Servant
2929
import Servant.Client qualified as ServantClient
3030
import System.Environment (lookupEnv)
@@ -38,7 +38,6 @@ import Data.Time.Clock qualified as Time
3838
import Network.HTTP.Client.TLS qualified as TLS
3939
import Network.HTTP.Client qualified as HTTPClient
4040
import Vault qualified
41-
import Data.ByteString.Char8 qualified as BSC
4241

4342
withEnv :: (Env () -> IO a) -> IO a
4443
withEnv action = do
@@ -133,11 +132,7 @@ withEnv action = do
133132
if Deployment.onLocal
134133
then TLS.newTlsManager
135134
else do
136-
httpProxyHost <- fromEnv "SHARE_PROXY_HOST" (\proxyHost -> case parseURI proxyHost of
137-
Nothing -> pure $ Left "Invalid SHARE_PROXY_ADDRESS"
138-
Just uri -> if uriScheme uri == "http:" || uriScheme uri == "https:"
139-
then pure $ Right (BSC.pack proxyHost)
140-
else pure $ Left "SHARE_PROXY_ADDRESS must be http or https")
135+
httpProxyHost <- fromEnv "SHARE_PROXY_HOST" ((fmap . fmap) Text.encodeUtf8 . nonEmptyTextParser "SHARE_PROXY_HOST")
141136
httpProxyPort <- fromEnv "SHARE_PROXY_PORT" (pure . maybeToEither "Invalid SHARE_PROXY_PORT" . readMaybe)
142137

143138
-- http proxy setup

0 commit comments

Comments
 (0)