Speed up incremental syncs#57
Merged
Merged
Conversation
ChrisPenner
force-pushed
the
cp/sync-speedups
branch
from
f7dcb00 to
ec56e0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously we'd fully expand the FULL history of all the known causals we're given, but that's excessive and also means incremental syncs slow down as history grows, which isn't what you want.
This PR changes things to instead crawl a single history node of all known hashes and just exclude those terms, which is perfectly good in most cases and starts sending results faster.
Also fixes a bug where not all excluded causals would be skipped, resulting in extra work being done.
Test coverage
Tested on staging