1 year session times#63
Merged
Merged
Conversation
ChrisPenner
force-pushed
the
cp/bump-session-ttl
branch
from
ad6432f to
ad7d896
Compare
hojberg
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
There's really no reason for sessions to be expiring so often.
If we need more control later on, we can add explicit session tracking in the DB, then just put a cutoff 'issued at' date in the JWT checker.
Implementation notes
Bump JWT sessions to 1 year long.
Loose ends
We should eventually add more fine grained session control