Store source/target causals on contribution itself, so they stay frozen once merged#69
Merged
Merged
Conversation
ChrisPenner
commented
May 9, 2025
f8ff7da to
a476f11
Compare
3b42512 to
c43252a
Compare
ad323ad to
844ced5
Compare
1 task
mitchellwrosen
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Now that contribution diffs depend on the target causal and not just the BCA we need to track that on the contribution itself so we can freeze it once merged.
Implementation notes
source_causal_idandtarget_causal_idon the contribution itself and update them when necessaryUse these causals when computing diffs rather than the current state of the referenced branches.
contribution_diff_queuewith a genericcausal_diff_queueso we ensure no diff calculations get accidentally rolled together, and also so we can use it for generic namespace diffsTest coverage