Include links in notification hub entries#81
Merged
Conversation
ChrisPenner
commented
May 27, 2025
| }, | ||
| "data": { | ||
| "kind": "projectBranchUpdated", | ||
| "link": "http://<HOST>:1234/@test/publictestproject/code/newbranch/latest", |
Member
Author
There was a problem hiding this comment.
@hojberg Here's all you need to care about :)
ChrisPenner
force-pushed
the
cp/hydrate-notification-links
branch
from
7b3f625 to
ac91fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a
linkfield to notifications which point to the relevant page for a notification.Implementation notes
One big additional change this includes is adding a
MonadReaderinstance for the app env in database transactions so I can hydrate links inside transactions; which doesn't come up often, but is used in the Webhook workerTest coverage
Transcripts