Update all old project permissions filters#83
Merged
Conversation
ChrisPenner
force-pushed
the
cp/update-project-permissions
branch
from
b530d55 to
48e9575
Compare
ChrisPenner
force-pushed
the
cp/update-project-permissions
branch
from
ce97f8d to
3833709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A bunch of old project permissions checks only knew about whether a project was public, owned by the caller, or part of an org, they didn't respect project-maintainer roles.
This updates all the relevant queries to use the new permissions system.
Affects:
Implementation notes
user_has_project_permissionSQL functionaccessible_private_projectsviewInteresting/controversial decisions
Include anything that you thought twice about, debated, chose arbitrarily, etc.
What could have been done differently, but wasn't? And why?
Test coverage