Skip to content

Add Notification Topic Groups#87

Merged
ChrisPenner merged 4 commits into
mainfrom
cp/topic-groups
Jun 2, 2025
Merged

Add Notification Topic Groups#87
ChrisPenner merged 4 commits into
mainfrom
cp/topic-groups

Conversation

@ChrisPenner
Copy link
Copy Markdown
Member

@ChrisPenner ChrisPenner commented May 30, 2025

Overview

  • Run migration

Adds notification topic groups so end users can subscribe to groups of topic semantically, e.g. "Watch Project" or "Subscribe to this ticket and its updates", but we can still expand these sets of topics the groups correspond to.

Implementation notes

  • Leaves the existing individual topic list so things like webhooks can still be specific about which events they want
  • Adds a list of subscribed topic groups to each subscription
  • Adds a topic group for watching everything in a project

Test coverage

  • Transcripts

@ChrisPenner ChrisPenner requested a review from hojberg May 30, 2025 16:47
Comment on lines +13 to 16
\"topics\": [],
\"topicGroups\": [
\"watch_project\"
],
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojberg creating subscriptions now requires both topics and topicGroups; but either can be empty.

@ChrisPenner ChrisPenner merged commit d498fb6 into main Jun 2, 2025
4 checks passed
@ChrisPenner ChrisPenner deleted the cp/topic-groups branch June 2, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant