Fix TFT fit_from_dataset future covariate validation#3149
Open
kiwoongyoon wants to merge 2 commits into
Open
Conversation
…co-darts-issue-3008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TFT fit_from_dataset future covariate validation
Summary
ValueErrorduring_create_model()when a custom training dataset has no future covariates andadd_relative_index=False.TFTModel.fit_from_dataset()withSequentialTorchTrainingDataset.Test evidence
UV_PROJECT_ENVIRONMENT=/tmp/gitcontribute-darts-issue-3008-venv uv run --with '.[torch]' --with pytest python -m pytest darts/tests/models/forecasting/test_TFT.py::TestTFTModel::test_future_covariate_handling -qpassed:1 passed, 4 warnings in 10.87s.git diff --checkpassed.python -m py_compile darts/models/forecasting/tft_model.py darts/tests/models/forecasting/test_TFT.pypassed.Risks or notes for maintainers
_build_train_dataset()validation to keep this patch narrowly scoped.uv.Fixes #3008